Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

노드 매트릭에 호스트명 추가 #292

Merged
merged 4 commits into from
Nov 17, 2023
Merged

노드 매트릭에 호스트명 추가 #292

merged 4 commits into from
Nov 17, 2023

Conversation

intelliguy
Copy link
Contributor

@intelliguy intelliguy commented Nov 16, 2023

node exporter에서 수집하는 데이터에 호스트명을 추가합니다.
이렇게 되면 추후 노드관련 매트릭 (ex. node_cpu_throttle ?, node_load_1....)에는 라벨들 중 hostname이라는 필드에 해당 머신의 hostname이 들어갑니다.
hostname을 영구적으로 적용한게 아니라면 이에 따른 시계열 데이터 분리(기존 호스트명 데이터와 바뀐 호스트명 데이터)가 있을수 있습니다.
이후 작업으로 기존에 instance를 기준으로 호스트를 판단했던 grafana dashboard들이 추가된 라벨을 사용하도록 수정하는 것을 권장합니다.

Base의 수정이므로 이것만 반영되면 이후 만들어지는 모든 클러스터에 반영됩니다.

@intelliguy intelliguy changed the base branch from develop to release November 17, 2023 06:40
Copy link

gitguardian bot commented Nov 17, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
8178259 Generic Database Assignment 6678ef2 tks-admin-tools/base/resources.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ktkfree ktkfree merged commit 68f09ba into release Nov 17, 2023
1 check passed
@ktkfree ktkfree deleted the node-ex-hostname branch November 17, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants