typo: fluentbit: remove garbage when define image #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelliguy
requested review from
zugwan,
bluejayA,
ktkfree,
robertchoi80,
seungkyua,
cho4036 and
Siyeop
| @@ -696,8 +696,8 @@ spec: | |||
| repository: harbor-cicd.taco-cat.xyz/tks/logalert-exporter | |||
| tag: v0.1.1 | |||
| fluentbit: | |||
| repository: harbor-cicd.taco-cat.xyz/tks/fluentbit | |||
| fluentbit.tag: v2.1.4 | |||
| repository: harbor-cicd.taco-cat.xyz/tks/fluent-bit | |||
There was a problem hiding this comment.
harbor 레지스트리에 fluentbit 과 fluent-bit 둘다 존재하는데, 후자가 맞는 거죠?
There was a problem hiding this comment.
kubesphere (원작자) 애들이 그렇게 명명했더라구요... 사실 매우 헛갈립니다.
fluentbit은 예전 upstream이 부족할때 직접 말아서 쓰던 이미지
There was a problem hiding this comment.
네~ 그럼 안 헷갈리게 전자는 harbor 에서 삭제해버리는게 깔끔하겠네요.
robertchoi80
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fluentbit 이미지 변경시 쓰레기 값이 섞여 들어갔습니다. 해당 내역을 삭제합니다.