prepare-etcd-secret: apply the label changes after v1.20 #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelliguy
requested review from
zugwan,
bluejayA,
ktkfree,
robertchoi80,
seungkyua,
kyuho24 and
Siyeop
bluejayA
suggested changes
Jun 23, 2023
bluejayA
approved these changes
Jun 23, 2023
bluejayA
approved these changes
Jun 23, 2023
ktkfree
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.20에서 마스터를 지칭하는 라벨이 바뀌었네요.
aws에서 eks 위주로 작업하는 현재는 발현되지 않지만 vm에 cluster 설치하면 발생하고 byoh 작업시에도 만나게 될 예정입니다.
이에 따라 수정해 놓는 것이며 주의 사항으로 site별로 이 값을 다시 override하고 있는데 이 내용도 과거버전의 라벨을 지칭하고 있습니다.
따라서 필요한 타이밍에는 수정이 필요