clustar-api-aws 정적 워커 노드 배포 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugwan
requested review from
ktkfree,
intelliguy,
robertchoi80,
seungkyua,
kyuho24 and
cho4036
|
This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
ktkfree
reviewed
Feb 6, 2023
| - taco-lma | ||
| - taco-ingress-gateway | ||
| - taco-egress-gateway | ||
| - servicemesh |
There was a problem hiding this comment.
삭제한 이유가 있을까요? 문맥상으로는 node label 설정하는 것 같은데.. 이거 workflow 에서 기존에 하던 작업이었을까요?
There was a problem hiding this comment.
BYOH 프로바이더 추가하면서 공통 작업을 workflow 수행 하도록 변경했었는데 일부 내용 제거가 누락되어 있었습니다.
https://github.com/openinfradev/tks-flow/blob/3c464dadd306ec39a03f4a05548f9072c9fe84cf/tks-cluster/create-usercluster-wftpl.yaml#L209
ktkfree
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openinfradev/helm-charts#165 사용을 위해 차트 버전을 업데이트 합니다.