Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Sentry): Get trace sample rate from env #63

Merged
merged 1 commit into from
Dec 3, 2021
Merged

chore(Sentry): Get trace sample rate from env #63

merged 1 commit into from
Dec 3, 2021

Conversation

qgerome
Copy link
Contributor

@qgerome qgerome commented Nov 4, 2021

No description provided.

edarchis
edarchis reviewed Nov 4, 2021
View reviewed changes
Copy link
Member

@edarchis edarchis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful that there is a Django trap there. When you specify the default setting, it is a float but if you override it from the environment, it will be a str. I don't know if sentry is handling it well.

@qgerome
Copy link
Contributor Author

qgerome commented Nov 5, 2021

Be careful that there is a Django trap there. When you specify the default setting, it is a float but if you override it from the environment, it will be a str. I don't know if sentry is handling it well.

Ok, I've added a float around it. Is it better like this ?

@qgerome qgerome requested a review from edarchis November 23, 2021 08:48
@qgerome
Copy link
Contributor Author

qgerome commented Nov 23, 2021

@edarchis UP

@edarchis edarchis merged commit 2c49d6f into develop Dec 3, 2021
@edarchis edarchis deleted the sentry-trace-rate branch December 3, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edarchis edarchis edarchis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qgerome @edarchis