Update wallet invocation section to mention Digital Credentials API #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leecam
reviewed
Dec 2, 2024
|
|
||
| For a cross device flow, either of the URL options MAY be presented as a QR code for the End-User to scan using a wallet or an arbitrary camera application on a user-device. | ||
|
|
||
| The Wallet can also be invoked from the web or a native app using the Digital Credentials API as described in (#dc_api). |
There was a problem hiding this comment.
I'd put this one first and if possible word it so it sounds like the preferred option :)
There was a problem hiding this comment.
I think we might get some pushback against essentially recommending it so I'd rather consider that separately. Opened #361 for that.
I think we can be clearer about the advantages though - @leecam @timcappalli could you check the new text please? Suggestions to improve it are welcome!
awoie
reviewed
Dec 2, 2024
Co-authored-by: Oliver Terbu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the 'no specific authorization endpoint' method that was never clearly specified and no one seems to be using.
closes #87
closes #262