Clarify what profiling OID4VP means #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
danielfett,
jogu,
tlodderstedt,
c2bo,
tplooker,
paulbastian,
awoie and
bc-pi
jogu
reviewed
Nov 20, 2024
Sakurann
commented
Nov 21, 2024
Co-authored-by: Joseph Heenan <[email protected]>
jogu
approved these changes
Nov 21, 2024
awoie
reviewed
Nov 28, 2024
| @@ -136,6 +136,11 @@ Implementations can also be built on top of OpenID Connect Core, which is also b | |||
|
|
|||
| Any of the OAuth 2.0 related specifications, such as [@RFC9126] and [@RFC9101], and Best Current Practice (BCP) documents, such as [@RFC8252] and [@I-D.ietf-oauth-security-topics], can be implemented on top of this specification. | |||
|
|
|||
| In summary, OpenID for Verifiable Presentations is a framework that requires profiling | |||
| to achieve interoperability. Out of the | |||
There was a problem hiding this comment.
This text is quite generic and I'm not sure if I would agree with the phrasing. The issue I have with the phrasing is that a profile can also have optional parameters, not only mandatory ones.
IMO, a profile does the following for a specific use case or ecosystem:
- define choices of values for mandatory and optional features, e.g., allowed credential format identifiers.
- define what optional features do not apply or mandate optional features, e.g., mandating encryption.
- optionally extend OID4VP if new features are required
This description is still vague but I could probably live with this better.
However, I think it would be better to define concretely what exactly has to be further defined by a profile.
Sakurann
commented
Nov 28, 2024
awoie
approved these changes
Nov 28, 2024
danielfett
approved these changes
Nov 28, 2024
Sakurann
commented
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text is adjusted to paraphrase where a term "profile" is not used as intended.