Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change credential format identifier for sd-jwt vc to dc+sd-jwt from vc+sd-jwt #328

Merged
merged 4 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/client_metadata/sd_jwt_vc_verifier_metadata.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"vp_formats": {
"vc+sd-jwt": {
"dc+sd-jwt": {
"sd-jwt_alg_values": ["ES256", "ES384"],
"kb-jwt_alg_values": ["ES256", "ES384"]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"nonce": "n-0S6_WzA2Mj",
"client_metadata": {
"vp_formats": {
"vc+sd-jwt": {
"dc+sd-jwt": {
"sd-jwt_alg_values": [ "PS256" ],
"kb-jwt_alg_values": [ "PS256" ]
}
Expand Down
2 changes: 1 addition & 1 deletion examples/query_lang/claims_alternatives.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"credentials": [
{
"id": "pid",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"meta": {
"vct_values": [ "https://credentials.example.com/identity_credential" ]
},
Expand Down
10 changes: 5 additions & 5 deletions examples/query_lang/credentials_alternatives.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"credentials": [
{
"id": "pid",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"meta": {
"vct_values": ["https://credentials.example.com/identity_credential"]
},
Expand All @@ -14,7 +14,7 @@
},
{
"id": "other_pid",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"meta": {
"vct_values": ["https://othercredentials.example/pid"]
},
Expand All @@ -26,7 +26,7 @@
},
{
"id": "pid_reduced_cred_1",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"meta": {
"vct_values": ["https://credentials.example.com/reduced_identity_credential"]
},
Expand All @@ -37,7 +37,7 @@
},
{
"id": "pid_reduced_cred_2",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"meta": {
"vct_values": ["https://cred.example/residence_credential"]
},
Expand All @@ -49,7 +49,7 @@
},
{
"id": "nice_to_have",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"meta": {
"vct_values": ["https://company.example/company_rewards"]
},
Expand Down
2 changes: 1 addition & 1 deletion examples/query_lang/multi_credentials.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"credentials": [
{
"id": "pid",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"meta": {
"vct_values": ["https://credentials.example.com/identity_credential"]
},
Expand Down
2 changes: 1 addition & 1 deletion examples/query_lang/simple.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"credentials": [
{
"id": "my_credential",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"meta": {
"vct_values": [ "https://credentials.example.com/identity_credential" ]
},
Expand Down
2 changes: 1 addition & 1 deletion examples/query_lang/value_matching_simple.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"credentials": [
{
"id": "my_credential",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"meta": {
"vct_values": [ "https://credentials.example.com/identity_credential" ]
},
Expand Down
2 changes: 1 addition & 1 deletion examples/request/pd_sd_jwt_vc.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{
"id": "identity_credential",
"format": {
"vc+sd-jwt": {
"dc+sd-jwt": {
"sd-jwt_alg_values": ["ES256", "ES384"],
"kb-jwt_alg_values": ["ES256", "ES384"]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
{
"id": "Example credential disclosing only address",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"path": "$[1]"
}
]
Expand Down
2 changes: 1 addition & 1 deletion examples/response/ps_sd_jwt_vc.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"id": "identity_credential",
"path": "$",
"format": "vc+sd-jwt"
"format": "dc+sd-jwt"
}
]
}
6 changes: 3 additions & 3 deletions examples/response/token_response_vp_token_sd_jwt_vc.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
eyJhbGciOiAiRVMyNTYiLCAidHlwIjogInZjK3NkLWp3dCIsICJraWQiOiAiZG9jLXNp
eyJhbGciOiAiRVMyNTYiLCAidHlwIjogImRjK3NkLWp3dCIsICJraWQiOiAiZG9jLXNp
Z25lci0wNS0yNS0yMDIyIn0.eyJfc2QiOiBbIjNvVUNuYUt0N3dxREt1eWgtTGdRb3p6
ZmhnYjhnTzVOaS1SQ1dzV1cydkEiLCAiOHo4ejlYOWpVdGI5OWdqZWpDd0ZBR3o0YXFs
SGYtc0NxUTZlTV9xbXBVUSIsICJDeHE0ODcyVVhYbmdHVUxUX2tsOGZkd1ZGa3lLNkFK
Expand All @@ -13,8 +13,8 @@ bXBsZS5jb20vaWRlbnRpdHlfY3JlZGVudGlhbCIsICJfc2RfYWxnIjogInNoYS0yNTYi
LCAiY25mIjogeyJqd2siOiB7Imt0eSI6ICJFQyIsICJjcnYiOiAiUC0yNTYiLCAieCI6
ICJUQ0FFUjE5WnZ1M09IRjRqNFc0dmZTVm9ISVAxSUxpbERsczd2Q2VHZW1jIiwgInki
OiAiWnhqaVdXYlpNUUdIVldLVlE0aGJTSWlyc1ZmdWVjQ0U2dDRqVDlGMkhaUSJ9fX0.
hBeB-fuMsIQ82QIE_674CSPIufs7w0D9CdfGdP_tGyBVp_vTSlbWb9MInFKSZ6Y3ie-r
0MMeSSEHyuUz9WNGSQ~WyJlbHVWNU9nM2dTTklJOEVZbnN4QV9BIiwgImZhbWlseV9uY
8eHLENOFGlZ7dcHSOCYzTu6BuBN8PqYnJCcPgGUh6XoxF6U6S5NVZq40cuLyvJqHZ56x
DGeQch0lBjLRKvS4Rw~WyJlbHVWNU9nM2dTTklJOEVZbnN4QV9BIiwgImZhbWlseV9uY
W1lIiwgIkRvZSJd~WyIyR0xDNDJzS1F2ZUNmR2ZyeU5STjl3IiwgImdpdmVuX25hbWUi
LCAiSm9obiJd~eyJhbGciOiAiRVMyNTYiLCAidHlwIjogImtiK2p3dCJ9.eyJub25jZS
I6ICJuLTBTNl9XekEyTWoiLCAiYXVkIjogImh0dHBzOi8vZXhhbXBsZS5jb20vdmVyaW
Expand Down
8 changes: 4 additions & 4 deletions examples/response/vp_token_multiple_vps.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"verificationMethod": "did:example:holder#key-1"
}
},
"eyJhbGciOiAiRVMyNTYiLCAidHlwIjogInZjK3NkLWp3dCIsICJraWQiOiAiZG9jLXNp
"eyJhbGciOiAiRVMyNTYiLCAidHlwIjogImRjK3NkLWp3dCIsICJraWQiOiAiZG9jLXNp
Z25lci0wNS0yNS0yMDIyIn0.eyJfc2QiOiBbIjA5dktySk1PbHlUV00wc2pwdV9wZE9C
VkJRMk0xeTNLaHBINTE1blhrcFkiLCAiMnJzakdiYUMwa3k4bVQwcEpyUGlvV1RxMF9k
YXcxc1g3NnBvVWxnQ3diSSIsICJFa084ZGhXMGRIRUpidlVIbEVfVkNldUM5dVJFTE9p
Expand All @@ -62,9 +62,9 @@
LmNvbS9pZGVudGl0eV9jcmVkZW50aWFsIiwgIl9zZF9hbGciOiAic2hhLTI1NiIsICJj
bmYiOiB7Imp3ayI6IHsia3R5IjogIkVDIiwgImNydiI6ICJQLTI1NiIsICJ4IjogIlRD
QUVSMTladnUzT0hGNGo0VzR2ZlNWb0hJUDFJTGlsRGxzN3ZDZUdlbWMiLCAieSI6ICJa
eGppV1diWk1RR0hWV0tWUTRoYlNJaXJzVmZ1ZWNDRTZ0NGpUOUYySFpRIn19fQ.D43eE
W1ae2yAzhzriJuBz-_cgX1wwNJIgNMjsdO28QE0fU8KC8ugjTPaylIp48HMVS0xV2wDQ
9bl1zFzlbDULg~WyJRZ19PNjR6cUF4ZTQxMmExMDhpcm9BIiwgImFkZHJlc3MiLCB7In
eGppV1diWk1RR0hWV0tWUTRoYlNJaXJzVmZ1ZWNDRTZ0NGpUOUYySFpRIn19fQ.BfCz7
bTCeExVLQUXuOUNSlPTD_xMraWG1nb7hPx-jbHXNY9hnu6sl3idGcqHF8LIKWD9OOvO-
oJMS0XfLlBwsg~WyJRZ19PNjR6cUF4ZTQxMmExMDhpcm9BIiwgImFkZHJlc3MiLCB7In
N0cmVldF9hZGRyZXNzIjogIjEyMyBNYWluIFN0IiwgImxvY2FsaXR5IjogIkFueXRvd2
4iLCAicmVnaW9uIjogIkFueXN0YXRlIiwgImNvdW50cnkiOiAiVVMifV0~eyJhbGciOi
AiRVMyNTYiLCAidHlwIjogImtiK2p3dCJ9.eyJub25jZSI6ICIxMjM0NTY3ODkwIiwgI
Expand Down
9 changes: 5 additions & 4 deletions openid-4-verifiable-presentations-1_0.md
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ claims:
## DCQL Examples {#dcql_query_example}

The following is a non-normative example of a DCQL query that requests a Verifiable
Credential of the format `vc+sd-jwt` with a type value of
Credential of the format `dc+sd-jwt` with a type value of
`https://credentials.example.com/identity_credential` and the claims `last_name`,
`first_name`, and `address.street_address`:

Expand Down Expand Up @@ -2242,7 +2242,7 @@ This section defines how Credentials complying with [@!I-D.ietf-oauth-sd-jwt-vc]

### Format Identifier

The Credential format identifier is `vc+sd-jwt`.
The Credential format identifier is `dc+sd-jwt`.

#### Example Credential

Expand Down Expand Up @@ -2287,7 +2287,7 @@ __Claim `birthdate`__:

### Verifier Metadata

The `format` value in the `vp_formats` parameter of the Verifier metadata MUST have the key `vc+sd-jwt`, and the value is an object consisting of the following name/value pairs:
The `format` value in the `vp_formats` parameter of the Verifier metadata MUST have the key `dc+sd-jwt`, and the value is an object consisting of the following name/value pairs:

* `sd-jwt_alg_values`: OPTIONAL. A JSON array containing identifiers of cryptographic algorithms the Verifier supports for signing of an Issuer-signed JWT of an SD-JWT. If present, the `alg` JOSE header (as defined in [@!RFC7515]) of the Issuer-signed JWT of the presented SD-JWT MUST match one of the array values.
* `kb-jwt_alg_values`: OPTIONAL. A JSON array containing identifiers of cryptographic algorithms the Verifier supports for signing of a Key Binding JWT (KB-JWT). If present, the `alg` JOSE header (as defined in [@!RFC7515]) of the presented KB-JWT MUST match one of the array values.
Expand All @@ -2313,7 +2313,7 @@ The following is a non-normative example of the contents of a `presentation_defi

<{{examples/request/pd_sd_jwt_vc.json}}

The presentation of an IETF SD-JWT VC is requested by adding an object named `vc+sd-jwt` to the `format` object of an `input_descriptor`. The `input_descriptor` value is applied to the unsecured payload of the IETF SD-JWT VC which correspond to the disclosures of the presented SD-JWT VC.
The presentation of an IETF SD-JWT VC is requested by adding an object named `dc+sd-jwt` to the `format` object of an `input_descriptor`. The `input_descriptor` value is applied to the unsecured payload of the IETF SD-JWT VC which correspond to the disclosures of the presented SD-JWT VC.

Setting `limit_disclosure` property defined in [@!DIF.PresentationExchange] to `required` enables selective release by instructing the Wallet to submit only the disclosures for the matching claims specified in the fields array. The unsecured payload of an IETF SD-JWT VC is used to perform the matching.

Expand Down Expand Up @@ -2677,6 +2677,7 @@ The technology described in this specification was made available from contribut
-23

* add `transaction_data` & `dcql_query` to list of allowed parameters in W3C Digital Credentials API appendix
* change media type `vc+sd-jwt` to `dc+sd-jwt` to align with draft 06 of [@!I-D.ietf-oauth-sd-jwt-vc]
charsleysa marked this conversation as resolved.
Show resolved Hide resolved


-22
Expand Down