Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change client_id_scheme to a prefix #263

Merged
merged 18 commits into from
Oct 3, 2024
Merged

Change client_id_scheme to a prefix #263

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e96e9b2
Change client_id_scheme to a prefix
danielfett Sep 13, 2024
35069dc
Fix examples and add examples for client ids
danielfett Sep 13, 2024
58b6fc3
Improve description
danielfett Sep 13, 2024
49c12b5
Further improve the description
danielfett Sep 13, 2024
87a42a8
Apply suggestions from Joseph's code review
danielfett Sep 13, 2024
a0f41da
Fix prefixes for the redirect_uri
danielfett Sep 13, 2024
182d024
Change PR to default to pre-registered clients in case no client id i…
danielfett Sep 17, 2024
dc843b0
Remove leftover prefix
danielfett Sep 17, 2024
93968ee
Remove client_id_scheme from examples, more precise wording in https …
Sep 18, 2024
9328668
Update openid-4-verifiable-presentations-1_0.md
danielfett Sep 19, 2024
1231449
Integrate Lukaszc' comment
danielfett Sep 23, 2024
74020a5
Merge branch 'main' into danielfett/client-id-scheme-prefixed
danielfett Sep 23, 2024
1db2a27
explain change in changelog
danielfett Sep 23, 2024
98f7495
Apply suggestions from code review
danielfett Sep 24, 2024
855e43a
Restructure Client ID Scheme section
Sep 24, 2024
b3d837a
Follow Brian's suggestions to fix the client id scheme in browser API…
danielfett Oct 1, 2024
433316d
Merge branch 'main' into danielfett/client-id-scheme-prefixed
danielfett Oct 1, 2024
38bf0dd
Remove reference to OpenID registration
danielfett Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/client_metadata/client_code_format.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"client_id": "s6BhdRkqt3",
"client_id": "pre-registered:s6BhdRkqt3",
danielfett marked this conversation as resolved.
Show resolved Hide resolved
"redirect_uri": "https://client.example.org/callback",
"token_endpoint_auth_method": "client_secret_basic",
"response_type": "code",
Expand Down
1 change: 0 additions & 1 deletion examples/digital_credentials_api/signed_request_payload.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"client_id": "https://client.example.org",
"client_id_scheme": "entity_id",
"expected_origins": [
"https://origin1.example.com",
"https://origin2.example.com"
Expand Down
1 change: 0 additions & 1 deletion examples/request/request_object_client_id_did.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"client_id": "did:example:123",
"client_id_scheme": "did",
"response_type": "vp_token",
"redirect_uri": "https://client.example.org/callback",
"nonce": "n-0S6_WzA2Mj",
Expand Down
Loading