Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed SPI hardware interlock test cases #1050

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

naichewa
Copy link
Contributor

@naichewa naichewa commented Nov 1, 2024

Removed the SPI interlock tests because the new SPI implementation does not pull PREADY low while transmitting/receiving. Pulling PREADY low hangs up the CPU for long periods of time. These tests attempted to update the SPI control registers to change clock modes, clock divider, etc during transmission. This is no longer allowed.

@rosethompson
Copy link
Contributor

I've added a comment to your PR so we have documentation as to why these tests are removed.

@rosethompson rosethompson merged commit a528e59 into openhwgroup:main Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants