Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new spi controller design. Designed as a proof of concept to see if timing issues can be fixed. I intend to work it into existing SPI peripheral. #1037

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

JacobPease
Copy link
Contributor

No description provided.

…see if timing issues can be fixed. I intend to work it into existing SPI peripheral.
@rosethompson
Copy link
Contributor

Can you add the SPDX header and your name and date?

@JacobPease
Copy link
Contributor Author

Oh yeah, hold on.

@rosethompson
Copy link
Contributor

As I understand, this handles clock generation, sampling SPIIN (pending?), and driving when SPIOUT changed? Do you think if we paired with is Naichi's fifos's and rest of the controller we could resolve our renaming issues?

@rosethompson
Copy link
Contributor

@MikeOpenHWGroup Jacob is getting a ECA failure despite having signed the agreement a long time ago. He's been able to make pull requests and not have issues in the past. We double checked and his email addresses in both commits match what's on file with eclipse. His eclipse account just says "An unexpected error has occurred."

@rosethompson
Copy link
Contributor

image(2)

@JacobPease
Copy link
Contributor Author

As I understand, this handles clock generation, sampling SPIIN (pending?), and driving when SPIOUT changed? Do you think if we paired with is Naichi's fifos's and rest of the controller we could resolve our renaming issues?

This will require more testing, but from what I've already tested, I think this should pair nicely with the FIFO's. Like you said, it generates the clock, shifting and sampling, and all delays. The different phase and polarity modes should be correct as well. Because of the timing of the signals, this should make sure that the FIFO's aren't desynchronized from the loading of the shift register, and loading the shift register won't cross frame boundaries either.

@rosethompson
Copy link
Contributor

@MikeOpenHWGroup Not sure what's going on, but the error went away.

@jordancarlin
Copy link
Member

@rosethompson I hit the revalidate button on the eclipse site and it seems to be working now. I’ve seen this issue with a few other PRs in the past too.

@rosethompson
Copy link
Contributor

I'm going to merge this as it's a good step in the right direction.

@rosethompson rosethompson merged commit ebd3576 into openhwgroup:main Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants