Add parameter to disable software interrupt. Fix issue #2500 #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ successful run, report available here. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
core/csr_regfile.sv
Outdated
Comment on lines
1443
to
1444
| mask = CVA6Cfg.XLEN'(riscv::MIP_MTIP) // same shift as MTIE | ||
| | CVA6Cfg.XLEN'(riscv::MIP_MEIP); // same shift as MEIE |
There was a problem hiding this comment.
[verible-verilog-format] reported by reviewdog 🐶
Suggested change
| mask = CVA6Cfg.XLEN'(riscv::MIP_MTIP) // same shift as MTIE | |
| | CVA6Cfg.XLEN'(riscv::MIP_MEIP); // same shift as MEIE | |
| mask = CVA6Cfg.XLEN'(riscv::MIP_MTIP) // same shift as MTIE | |
| | CVA6Cfg.XLEN'(riscv::MIP_MEIP); // same shift as MEIE |
core/include/config_pkg.sv
Outdated
Comment on lines
282
to
283
| bit RVS; //Supervisor mode | ||
| bit RVU; //User mode |
There was a problem hiding this comment.
[verible-verilog-format] reported by reviewdog 🐶
Suggested change
| bit RVS; //Supervisor mode | |
| bit RVU; //User mode | |
| bit RVS; //Supervisor mode | |
| bit RVU; //User mode |
core/include/config_pkg.sv
Outdated
Comment on lines
394
to
398
| // Support for disabling MIP.MSIP and MIE.MSIE in Hypervisor and Supervisor mode is not supported | ||
| // Software Interrupt can be disabled when there is only M machine mode in CVA6. | ||
| assert (!(Cfg.RVS && !Cfg.SoftwareInterruptEn)) | ||
| assert (!(Cfg.RVH && !Cfg.SoftwareInterruptEn)) | ||
| else $fatal(1, "[frontend] fetch width != not supported"); |
There was a problem hiding this comment.
[verible-verilog-format] reported by reviewdog 🐶
Suggested change
| // Support for disabling MIP.MSIP and MIE.MSIE in Hypervisor and Supervisor mode is not supported | |
| // Software Interrupt can be disabled when there is only M machine mode in CVA6. | |
| assert (!(Cfg.RVS && !Cfg.SoftwareInterruptEn)) | |
| assert (!(Cfg.RVH && !Cfg.SoftwareInterruptEn)) | |
| else $fatal(1, "[frontend] fetch width != not supported"); | |
| // Support for disabling MIP.MSIP and MIE.MSIE in Hypervisor and Supervisor mode is not supported | |
| // Software Interrupt can be disabled when there is only M machine mode in CVA6. | |
| assert (!(Cfg.RVS && !Cfg.SoftwareInterruptEn)) | |
| assert (!(Cfg.RVH && !Cfg.SoftwareInterruptEn)) | |
| else $fatal(1, "[frontend] fetch width != not supported"); |
core/include/config_pkg.sv
Outdated
Comment on lines
282
to
283
| bit RVS; //Supervisor mode | ||
| bit RVU; //User mode |
There was a problem hiding this comment.
[verible-verilog-format] reported by reviewdog 🐶
Suggested change
| bit RVS; //Supervisor mode | |
| bit RVU; //User mode | |
| bit RVS; //Supervisor mode | |
| bit RVU; //User mode |
core/include/config_pkg.sv
Outdated
Comment on lines
394
to
398
| // Support for disabling MIP.MSIP and MIE.MSIE in Hypervisor and Supervisor mode is not supported | ||
| // Software Interrupt can be disabled when there is only M machine mode in CVA6. | ||
| assert (!(Cfg.RVS && !Cfg.SoftwareInterruptEn)) | ||
| assert (!(Cfg.RVH && !Cfg.SoftwareInterruptEn)) | ||
| else $fatal(1, "[frontend] fetch width != not supported"); |
There was a problem hiding this comment.
[verible-verilog-format] reported by reviewdog 🐶
Suggested change
| // Support for disabling MIP.MSIP and MIE.MSIE in Hypervisor and Supervisor mode is not supported | |
| // Software Interrupt can be disabled when there is only M machine mode in CVA6. | |
| assert (!(Cfg.RVS && !Cfg.SoftwareInterruptEn)) | |
| assert (!(Cfg.RVH && !Cfg.SoftwareInterruptEn)) | |
| else $fatal(1, "[frontend] fetch width != not supported"); | |
| // Support for disabling MIP.MSIP and MIE.MSIE in Hypervisor and Supervisor mode is not supported | |
| // Software Interrupt can be disabled when there is only M machine mode in CVA6. | |
| assert (!(Cfg.RVS && !Cfg.SoftwareInterruptEn)) | |
| assert (!(Cfg.RVH && !Cfg.SoftwareInterruptEn)) | |
| else $fatal(1, "[frontend] fetch width != not supported"); |
core/include/config_pkg.sv
Outdated
Comment on lines
394
to
398
| // Support for disabling MIP.MSIP and MIE.MSIE in Hypervisor and Supervisor mode is not supported | ||
| // Software Interrupt can be disabled when there is only M machine mode in CVA6. | ||
| assert (!(Cfg.RVS && !Cfg.SoftwareInterruptEn)) | ||
| assert (!(Cfg.RVH && !Cfg.SoftwareInterruptEn)) | ||
| else $fatal(1, "[frontend] fetch width != not supported"); |
There was a problem hiding this comment.
[verible-verilog-format] reported by reviewdog 🐶
Suggested change
| // Support for disabling MIP.MSIP and MIE.MSIE in Hypervisor and Supervisor mode is not supported | |
| // Software Interrupt can be disabled when there is only M machine mode in CVA6. | |
| assert (!(Cfg.RVS && !Cfg.SoftwareInterruptEn)) | |
| assert (!(Cfg.RVH && !Cfg.SoftwareInterruptEn)) | |
| else $fatal(1, "[frontend] fetch width != not supported"); | |
| // Support for disabling MIP.MSIP and MIE.MSIE in Hypervisor and Supervisor mode is not supported | |
| // Software Interrupt can be disabled when there is only M machine mode in CVA6. | |
| assert (!(Cfg.RVS && !Cfg.SoftwareInterruptEn)) | |
| assert (!(Cfg.RVH && !Cfg.SoftwareInterruptEn)) | |
| else $fatal(1, "[frontend] fetch width != not supported"); |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #2500
Add parameter to disable software interrupt.
MIP.MSIP and MIE.MSIE are now read only when this parameter is disabled.