Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed todo about local vs flopped intsr_valid within the bypass mod… #899

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Removed todo about local vs flopped intsr_valid within the bypass mod… #899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions rtl/cv32e40x_controller_bypass.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,6 @@ module cv32e40x_controller_bypass import cv32e40x_pkg::*;
// - The hazard here is really between EX (CSR read) and WB (CSR write). This stall works by creating a bubble in EX while the the
// 'offending' write moves to WB (mscratchcsw[l] stays in ID.) Since we don't squash bubbles this should be safe.

// todo:low:Above loop reasoning only applies to halt_id; for other pipeline stages a local instr_valid signal can maybe be used.

// Detect when a CSR insn in in EX or WB
// mret, dret and CLIC pointers implicitly writes to CSR. (dret is killing IF/ID/EX once it is in WB and can be disregarded here.
assign csr_write_in_ex_wb = (
Expand Down