Removed two no longer relevant TODO's in id_stage. #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oystein Knauserud <[email protected]>
Silabs-ArjanB
requested changes
Apr 28, 2023
rtl/cv32e40x_id_stage.sv
Outdated
| @@ -695,15 +695,14 @@ module cv32e40x_id_stage import cv32e40x_pkg::*; | |||
| assign sys_en_o = sys_en; | |||
|
|
|||
| // stall control for multicyle ID instructions (currently only misaligned LSU) | |||
| assign multi_cycle_id_stall = 1'b0; //todo:ok Zce push/pop will use this | |||
| assign multi_cycle_id_stall = 1'b0; | |||
There was a problem hiding this comment.
I don't understand the comment about misaligned LSU. Shouldn't we just remove this signal all together if it is not going to be used?
There was a problem hiding this comment.
That's true. It is used on E40S for splitting hardened jumps and branches, but not on E40X. I will remove it.
…this signal was tied to 0 and the original intention for the signal is no longer valid. SEC clean Signed-off-by: Oystein Knauserud <[email protected]>
Silabs-ArjanB
approved these changes
Apr 28, 2023
Silabs-ArjanB
added
the
Component:RTL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.