Fix literal width #827
Merged
Fix literal width #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mole99 Thank you very much for your contribution! Before merging it I would kindly like to ask you to sign the so-called Eclipse Contributor Agreement (ECA). You can find more information on https://www.eclipse.org/projects/handbook/#contributing-eca and https://www.eclipse.org/legal/ECA.php. Best regards, |
Silabs-ArjanB
added
the
Component:RTL
|
Hi Arjan, I created an account and signed the ECA:
But it seems to not recognize my ECA sign-off status. I made sure to use the same e-mail address. Do you have a suggestion what I could try? Thanks! |
|
Did you do the commit using the -s option for git commit? |
Signed-off-by: mole99 <[email protected]>
|
Thanks, that was the issue :D |
Silabs-ArjanB
approved these changes
Apr 6, 2023
|
Thank you very much @mole99 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a minor issue with the width of a literal that triggered a warning with the sv2v converter.