Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for cv32e40s issue 415 #806

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

silabs-oivind
Copy link
Contributor

@silabs-oivind silabs-oivind commented Mar 16, 2023

Fix for openhwgroup/cv32e40s#415
SEC clean, except for debug_pc_o.

Signed-off-by: Oivind Ekelund <[email protected]>
Copy link
Contributor

@Silabs-ArjanB Silabs-ArjanB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. The comment in the PR however states that this is a SEC clean change. That cannot be true if it is also a bug fix. Can you please explain.

@silabs-oivind
Copy link
Contributor Author

@Silabs-ArjanB. You're right! It's SEC clean for all signals but debug_pc_o.

@Silabs-ArjanB Silabs-ArjanB added the Component:RTL For issues in the RTL (e.g. for files in the rtl directory) label Mar 16, 2023
@Silabs-ArjanB Silabs-ArjanB merged commit b22444c into openhwgroup:master Mar 16, 2023
@silabs-oivind silabs-oivind deleted the fix_e40s_issue_415 branch March 16, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants