CLIC: Spec chapter 5.1 #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SR when SMCLIC=1. Signed-off-by: Oystein Knauserud <[email protected]>
Signed-off-by: Oystein Knauserud <[email protected]>
…tatus. Signed-off-by: Oystein Knauserud <[email protected]>
Silabs-ArjanB
requested changes
Mar 23, 2022
| CSR_MCAUSE: begin | ||
| if (SMCLIC) begin | ||
| // For CLIC, the mpp and mpie bits from mstatus | ||
| // are readable via mcause |
There was a problem hiding this comment.
Add note that 'CLIC mode is assumed when SMCLIC = 1'. RTL should actually have checked on 'clic mode' instead of SMCLIC, but let's keep it like this as these two things are the same for our subset of the Smclic implementation (and your implementation is better for coverage reasons)
rtl/cv32e40x_cs_registers.sv
Outdated
| default: 'b0 | ||
| }; | ||
| if (SMCLIC) begin | ||
| // SMCLIC: A write to mcause.mpp or mcause.mpie is stored in mstatus |
There was a problem hiding this comment.
Same remark as above: 'CLIC mode is assumed when SMCLIC = 1'.
rtl/cv32e40x_cs_registers.sv
Outdated
| mstatus_n.mpie = csr_wdata_int[MCAUSE_MPIE_BIT]; | ||
| end else begin | ||
| // TODO: add support for SD/XS/FS/VS | ||
| mstatus_n = '{ |
There was a problem hiding this comment.
Reorganize code to avoid this code duplication. Simply first do the original mstatus_n assignment and then a if (SMCLIC) if (mcause_we)
…lication. Signed-off-by: Oystein Knauserud <[email protected]>
Silabs-ArjanB
approved these changes
Mar 24, 2022
Silabs-ArjanB
added
the
Component:RTL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making mstatus.mpie and mstatus.mpp accessible via mcause.
SEC clean with SMCLIC=0