Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'parameter int' into 'parameter int unsigned' #676

Closed
Silabs-ArjanB opened this issue Sep 28, 2022 · 2 comments
Closed

Change 'parameter int' into 'parameter int unsigned' #676

Silabs-ArjanB opened this issue Sep 28, 2022 · 2 comments

Comments

@Silabs-ArjanB
Copy link
Contributor

This is to match the CORE-V-XIF specification. Also all other use of 'parameter int' does not make sense and should be changed into 'parameter int unsigned'.

This applies to the entire repos bhv, rtl, doc, etc. (and to surrounding modules instantiating this core)
silabs-oivind added a commit to silabs-oivind/cv32e40x that referenced this issue Mar 24, 2023
@silabs-oivind
Clean up parameter types. Fix for issue openhwgroup#676
d577d3a 
Signed-off-by: Oivind Ekelund <[email protected]>
Silabs-ArjanB added a commit that referenced this issue Mar 24, 2023
@Silabs-ArjanB
Merge pull request #813 from silabs-oivind/param_update
85cabe2 
Clean up parameter types. Fix for issue #676
silabs-oivind added a commit to silabs-oivind/cv32e40s that referenced this issue Apr 3, 2023
@silabs-oivind
Parameter cleanup. Part of fix for openhwgroup/cv32e40x#676
a711891 
Signed-off-by: Oivind Ekelund <[email protected]>
silabs-oivind added a commit to silabs-oivind/cv32e40x that referenced this issue Apr 3, 2023
@silabs-oivind
Remove unused parameter DEBUG_TRIGGER_EN. Add explicit parameter types.
0fd2e60 
Part of fix for openhwgroup#676

Signed-off-by: Oivind Ekelund <[email protected]>
@silabs-oivind silabs-oivind mentioned this issue Apr 3, 2023
Merged
@Silabs-ArjanB
Copy link
Contributor Author

Hi @silabs-oivind Can this issue be closed now?

@silabs-oivind
Copy link
Contributor

Member

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Silabs-ArjanB @silabs-oivind