Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional feedback on https://github.com/openhwgroup/cv32e40x/pull/661 #668

Closed
Silabs-ArjanB opened this issue Sep 22, 2022 · 2 comments
Closed

Additional feedback on https://github.com/openhwgroup/cv32e40x/pull/661 #668

Silabs-ArjanB opened this issue Sep 22, 2022 · 2 comments
Labels
Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation

Comments

@Silabs-ArjanB
Copy link
Contributor

Please see #661 for additional feedback on the already merged pull request.
@Silabs-ArjanB
Copy link
Contributor Author

The described issue related to mscratchcsw_rdata can be addressed by using a rmask such that the rdata is only valid when an actual mscratchcsw CSR happens. The same fix should be done for other CSRs where the rdata is not always considered to be valid (e.g. mnxti?).

Silabs-ArjanB added a commit that referenced this issue Dec 21, 2022
@Silabs-ArjanB
Merge pull request #741 from silabs-oysteink/silabs-oysteink_issue-668
cf0b27c 
Fix for issue #668
@silabs-oysteink
Copy link
Contributor

This should have been fixed with PR #741.

@silabs-oysteink silabs-oysteink added the Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status:Resolved Issue has been resolved, but closure is pending on git merge and/or issuer confirmation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Silabs-ArjanB @silabs-oysteink