Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper wb_valid semantics for CLIC pointer fetches and multi operation instructions #497

Closed
silabs-oysteink opened this issue Apr 6, 2022 · 2 comments
Closed

Implement proper wb_valid semantics for CLIC pointer fetches and multi operation instructions #497

silabs-oysteink opened this issue Apr 6, 2022 · 2 comments

Comments

@silabs-oysteink
Copy link
Contributor

Currently, a CLIC pointer that arrives in WB will not signal wb_valid, and RVFI is not notified of the pointer.
Similarly, split LSU accesses only signal wb_valid for the last operation, not the first.

Wb_valid should be set for all cycles where a valid instruction or part of an instruction is done in WB (similar to id_valid and ex_valid for instance). RVFI would need to adapt to this by for instance checking the 'last' bit inside it's pipeline model.
@silabs-oysteink silabs-oysteink mentioned this issue Apr 6, 2022
Merged
Silabs-ArjanB added a commit that referenced this issue Oct 4, 2022
@Silabs-ArjanB
Merge pull request #682 from silabs-oysteink/silabs-oysteink_clic-ptr…
789a0c1 
…-wb_valid

Fix for issue #497
@Silabs-ArjanB
Copy link
Contributor

@silabs-oysteink Can this issue be closed now?

@silabs-oysteink
Copy link
Contributor Author

Yes, everything mentioned above is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Silabs-ArjanB @silabs-oysteink