Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jrubyscripting to automation add-ons #305

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Nov 16, 2021

For the newly merged jrubyscripting automation add-on. There doesn't seem to be any specific rule for ordering the items.

@ghys
Copy link
Member

ghys commented Nov 22, 2021

Actually now I would start to feature the major script languages add-ons (JS, Jython, JRuby, Groovy) since there are now 4 of them, and "unfeature" the more esoteric/niche ones like pidcontroller (no offense!).
This would be done by removing the "all: true" parameter.
I'd still appreciate if there was a JRuby logo in the docs repo before I merge this.

@jimtng
Copy link
Contributor Author

jimtng commented Nov 22, 2021

I'd still appreciate if there was a JRuby logo in the docs repo before I merge this.

Hi Yannick, thanks for your work. The jruby logo can be found here https://github.com/jruby/collateral
I know you've explained about the legalities, but I'm still paranoid about submitting a PR related to logos, so if you wouldn't mind doing it, it would be great thanks.

"unfeature" the more esoteric/niche ones like pidcontroller (no offense!).

There seem to be two different sub-categories within "automation", i.e. general scripting languages, vs specialised automation.

@Confectrician
Copy link
Contributor

@ghys the logo should be available now.

Anything we need to wait for or could this pr get merged?

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope :)

@ghys ghys merged commit d4d8c84 into openhab:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants