Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map and Set to have consistent XML serialization order #1642

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

ssalonen
Copy link
Contributor

Resolves #1641

Signed-off-by: Sami Salonen [email protected]

*/
public class OrderingSetConverter extends CollectionConverter {

public static boolean allSameClassAndComparable(Set<@Nullable ?> src) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssalonen
Copy link
Contributor Author

ssalonen commented Jul 31, 2021

The tests asserting ordering fail on my machine when uncommenting additions in ZWaveNodeSerializer (this is good -- means that by default on my machine stuff is not ordered).

Short snippet from meld how the serialization changes

image
xml_comparison.patch.txt

@ssalonen
Copy link
Contributor Author

@cdjackson anything I can do to support in the review process?

@cdjackson
Copy link
Collaborator

Sorry - I did look over this some time back and through I'd merged already.

Thanks @ssalonen

@cdjackson cdjackson merged commit 67fec3f into openhab:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Consistent serialization of XML to avoid unnecessary changes
2 participants