Force associations in specific circumstances #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
cdjackson
force-pushed
the
force_association
branch
3 times, most recently
from
e341d68 to
0326bf2
Compare
|
Updated to try and resolve incorrect parsing of arrays from elsewhere in the system! |
cdjackson
force-pushed
the
force_association
branch
2 times, most recently
from
2a80f63 to
b1fb379
Compare
Signed-off-by: Chris Jackson <[email protected]>
cdjackson
force-pushed
the
force_association
branch
from
b1fb379 to
f11db5f
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/fibaro-motion-sensor-fgms001-gen5-zwaveplus/16183/165 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent associations being removed if the system needs them, and the controller is configured as
master. The PR searches to see if the database has an association configured, or if the association is the ZWave PlusLifelinegroup. If so, it will set the association - thus preventing the user from removing it.This is to avoid the system becoming unusable due to either lack of knowledge by users, or, through UI problems causing associations to be removed.
It also transpired that somewhere in the system (either in the UI, or in ESH) the arrays/lists are not being parsed correctly and the array is being presented as a string (eg
[node_1, node_2]). Code has now been added to handle this format!Signed-off-by: Chris Jackson [email protected]