Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zigbee] Add a color temperature absolute channel #868

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

andrewfg
Copy link
Contributor

This is a draft PR as proof of concept for potentially adding a color temperature absolute channel in addition to the already existing color temperature percent channel. Initiall for discussion purposes only.

Resolves #867
See openhab/openhab-core#3891

Signed-off-by: AndrewFG [email protected]

Copy link
Contributor

@cdjackson cdjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few initial comments...

I know this is still WIP but I was following the other thread and thought I'd take a look.

@andrewfg
Copy link
Contributor Author

@cdjackson I think the code is quite clean now. I will set up my test rig and run real tests tomorrow.

Signed-off-by: AndrewFG <[email protected]>
@andrewfg
Copy link
Contributor Author

andrewfg commented Oct 30, 2024

@cdjackson I did some refactoring. I tested this version and can confirm that it all seems to be working fine. Note however, that I wanted to add the new channel to the documentation but I discovered that in the ChannelUID table many of the other IDs are in fact wrong -- so it is not only an issue of adding one line to that table. I can easily make the corrections if you want, but perhaps you have some thoughts on this? => WDYT?

EDIT: I committed a minor fix to the channel type ids, and added some documentation changes and extensions

@cdjackson
Copy link
Contributor

cdjackson commented Oct 31, 2024 via email

@cdjackson
Copy link
Contributor

Thanks @andrewfg LGTM.

@cdjackson cdjackson merged commit 61fb4da into openhab:main Nov 5, 2024
2 checks passed
@cdjackson cdjackson added this to the 4.3 milestone Nov 5, 2024
@andrewfg andrewfg deleted the color-temp-min-max branch November 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New channel for absolute Color Temperature with UoM?
2 participants