Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle OnWithTimedOffCommand #481

Merged
merged 3 commits into from
Sep 16, 2019
Merged

Conversation

cdjackson
Copy link
Contributor

As discussed in #479 some devices are sending the OnWithTimedOffCommand. This adds initial support for this command to turn the channel ON and implement the timed OFF.

Signed-off-by: Chris Jackson [email protected]

@cdjackson cdjackson added this to the 2.5 milestone Sep 14, 2019
Signed-off-by: Chris Jackson <[email protected]>
@cdjackson
Copy link
Contributor Author

@triller-telekom can you review please.

Copy link
Contributor

@triller-telekom triller-telekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. (I assume the OnWithTimedOffCommand is handled in ZSS correctly already)

@cdjackson
Copy link
Contributor Author

ZSS doesn't do anything with the command - it just passes it out to any command listeners. You can see this in the log at the top of #479.

@cdjackson cdjackson closed this Sep 16, 2019
@cdjackson cdjackson reopened this Sep 16, 2019
@cdjackson cdjackson merged commit 45da9c4 into openhab:master Sep 16, 2019
@cdjackson cdjackson deleted the timed_on_off branch September 16, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants