Illuminance configuration improvements #468
Conversation
Signed-off-by: Chris Jackson <[email protected]>
Signed-off-by: Chris Jackson <[email protected]>
|
I would prefer not to have to waste time refactoring to be honest. The development of these features was interlinked which is why they ended up in a single branch and splitting them seems unnecessary even if in an ideal world we should only have one change per branch. Is that ok? Otherwise it will be next week before I can look at this I think. |
|
Updated. |
There was a problem hiding this comment.
Sorry, I just found the time to do a further review.
As far as I understand the code, there CAN be a channel configuration specifying the reporting intervals. If there is none, the reporting uses the defaults as before. Am I right? Then, this PR contains the illuminance fix and a preparation of the channelconverter to support reporting intervals as a channel configuration, I am fine with that.
I just found 2 copy&paste mistakes, please have a look.
| if (configuration.containsKey(CONFIG_REPORTINGMIN)) { | ||
| reportingTimeMin = ((BigDecimal) configuration.get(CONFIG_REPORTINGMIN)).intValue(); | ||
| } | ||
| if (configuration.containsKey(CONFIG_REPORTINGMIN)) { |
There was a problem hiding this comment.
I think there is a copy&paste error here: should be CONFIG_REPORTINGMAX
| reportingTimeMin = ((BigDecimal) configuration.get(CONFIG_REPORTINGMAX)).intValue(); | ||
| } | ||
| if (configuration.containsKey(CONFIG_REPORTINGMIN)) { | ||
| reportingTimeMin = ((BigDecimal) configuration.get(CONFIG_REPORTINGCHANGE)).intValue(); |
There was a problem hiding this comment.
I think there is a copy&paste error here: should be CONFIG_REPORTINGCHANGE
Edit: I meant the line above, but I guess you know what I mean :)
No - I split the illuminance fix into #469 I'll update with the errors - well spotted, thanks. |
Signed-off-by: Chris Jackson <[email protected]>
|
Thanks Stefan |
This PR includes changes to the reporting configuration class
ZclReportingConfig. This now supports changing the reporting change, and also the reporting min/max times.@triller-telekom I'd welcome your review on this.
Note that there will be a subsequent PR to improve the handling of reporting configuration which is possible with the way reporting is now handled in the latest ZSS, but I'd like to get this merged as it already covers more than one feature.
Signed-off-by: Chris Jackson [email protected]