Fixed handling of IAS Zone Refresh #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Jackson <[email protected]>
|
I've modified this slightly to now add an attribute listener. Previously this wouldn't have worked. I'd like to get this merged quickly - if we can get the CI to work! @kaikreuzer any ideas on this (it's been broken for a week)? I posted a message on the openhab maintainers list, but I guess everyone is still on holiday... |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
hsudbrock
reviewed
Jan 14, 2019
| @Override | ||
| public void attributeUpdated(ZclAttribute attribute) { | ||
| logger.debug("{}: ZigBee attribute reports {}", endpoint.getIeeeAddress(), attribute); | ||
| if (attribute.getCluster() == ZclClusterType.OCCUPANCY_SENSING |
There was a problem hiding this comment.
One question, Chris: Why should this code relating to occupancy sensing go into the abstract base class for all IAS converters. Isn't this something that should only go into the subclasses that deal with occupancy sensing?
|
Oops- cut and paste error :(. I’ll sort this later - thanks.
…Sent from my iPhone
On 14 Jan 2019, at 13:45, Henning Sudbrock ***@***.***> wrote:
@hsudbrock commented on this pull request.
In org.openhab.binding.zigbee/src/main/java/org/openhab/binding/zigbee/internal/converter/ZigBeeConverterIas.java:
> - case "Contact":
- updateChannelState(((zoneStatus.getZoneStatus() & bitTest) != 0) ? OpenClosedType.OPEN
- : OpenClosedType.CLOSED);
- break;
- default:
- logger.warn("{}: Unsupported item type {}", endpoint.getIeeeAddress(),
- channel.getAcceptedItemType());
- break;
+ updateChannelState(zoneStatus.getZoneStatus());
+ }
+ }
+
+ @OverRide
+ public void attributeUpdated(ZclAttribute attribute) {
+ logger.debug("{}: ZigBee attribute reports {}", endpoint.getIeeeAddress(), attribute);
+ if (attribute.getCluster() == ZclClusterType.OCCUPANCY_SENSING
One question, Chris: Why should this code relating to occupancy sensing go into the abstract base class for all IAS converters. Isn't this something that should only go into the subclasses that deal with occupancy sensing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Signed-off-by: Chris Jackson <[email protected]>
cdjackson
force-pushed
the
ias_zone_refresh
branch
from
118766c to
3469183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
handleRefreshmethod was not updating the state.Signed-off-by: Chris Jackson [email protected]