Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of OTA initialisation #319

Merged
merged 3 commits into from
Dec 9, 2018
Merged

Conversation

cdjackson
Copy link
Contributor

@hanneshofmann this ought to resolve the issue with the OTA initialisation. I've not tested it as it will fail compilation at the moment until the libraries are updated.
Closes #312
Signed-off-by: Chris Jackson [email protected]

Copy link

@hanneshofmann hanneshofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement - the code looks good to me and my local tests were successful (using this PR and zsmartsystems/com.zsmartsystems.zigbee#443) . I think we could merge it as soon as the libraries are updated.

As already pointed out in #312, there are still some problems to fully update the device firmware due to some transactions timeouts. Since these timeouts seem unrelated to the OTA initialization, I will collect some logs and I will create a new issue for that.

@cdjackson
Copy link
Contributor Author

Thanks. The timeouts may be device issues (some devices don't respond to the final message in the transfer), but as mentioned, raise an issue and provide the logs and I'll take a look.

@cdjackson
Copy link
Contributor Author

Requires #332

@cdjackson
Copy link
Contributor Author

Merging as already reviewed above by @hanneshofmann

@cdjackson cdjackson merged commit 4dc7a53 into openhab:master Dec 9, 2018
@cdjackson cdjackson deleted the ota_fix branch December 9, 2018 21:47
@cdjackson cdjackson added this to the 2.5 milestone Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device FW update fails due to incorrect determination of OTA server, cluster and endpoint
2 participants