Download and install Zulu Embedded Java from .tar #459

mstormi · 2018-11-02T16:30:18Z

We need to change the installation method of Zulu Java as Azul systems does not maintain Java repos any more.

Signed-off-by: Markus Storm [email protected] (github: mstormi)

Signed-off-by: Markus Storm <[email protected]>

We need to change the installation method of Zulu Java as Azul systems does not maintain Java repos any more.

mstormi · 2018-11-02T16:33:47Z

To fix #457 and #453.
See also #450.

BClark09 · 2018-11-10T15:00:51Z

functions/java-jre.sh

+  if is_arm; then
+    JAVA=zulu8.31.1.122-jdk1.8.0_181-linux_aarch32hf
+  else
+    JAVA=zulu8.31.0.1-jdk8.0.181-linux_x64


Should we assume here that anything not arm is 64-bit?

We have no check for 32/64 bit and latest Zulu is not available in 64 bit on x86 so I think it is somewhat safe to assume that we want this to be 64bit always, wdyt?

BClark09 · 2018-11-10T15:02:40Z

functions/java-jre.sh

+  else
+    JAVA=zulu8.31.0.1-jdk8.0.181-linux_x64
+  fi
+  querytext="Downloading Zulu implies to agree to Azul Systems' Terms of Use. Display them now or proceed with downloading."


Quick check from @kaikreuzer, is copying the terms of use and displaying them here sufficient in your opinion?

note that as part of the install the user also has to confirm he read the terms

BClark09

Hi @mstormi, thanks for this. I had a few comments and checks before merging.

functions/java-jre.sh

EliasGabrielsson · 2018-11-13T16:08:37Z

Thanks @BClark09 for the reviewing!
I have some time this upcoming weekend for test and merge PR:s.

due to tmpfs potentially exceeded

and use local variables

BClark09 · 2018-12-21T14:44:14Z

@mstormi would you be willing to rebase your PR or resolve the conflicts?

ThomDietrich

Hey @mstormi thanks for handling the issue! I've added a few comments but I hope that none of them take much time to attend to! Enjoy your holidays! ;)

ThomDietrich · 2018-12-26T13:05:53Z

docs/azul_zulu_license.md

+Azul is not obligated to provide you with any support for Zulu (unless you have entered into a separate written agreement for such support,
+in which case such separate agreement shall apply).
+You also represent and warrant that you do not intend to distribute the software in a manner that is not compliant with relevant export control
+laws or regulations administered by the U.S. Commerce Department, OFAC, or any other government agency.


Is this file copy-pasted from here? https://www.azul.com/products/zulu-and-zulu-enterprise/zulu-terms-of-use/
If so I'd suggest to (1) reformat it and (2) additionally show the link as a source and for users to follow.

ThomDietrich · 2018-12-26T13:12:45Z

functions/java-jre.sh

+  local FILE="/var/tmp/.zulu.$$"
+  local INSTALLROOT=/opt/jdk
+
+  if is_arm; then


Please add a comment with the following URL above: https://www.azul.com/downloads/zulu-embedded

I'm not at all a fan of adding the version number as a fixed string. Could you please reach out their forum to find out if there is a static redircting link. You can also use the chance to ask about their Terms of Use.
This request should not block the merge of this PR.

functions/java-jre.sh

ThomDietrich · 2018-12-26T13:18:09Z

functions/java-jre.sh

+  fi
+  querytext="Downloading Zulu implies to agree to Azul Systems' Terms of Use. Display them now or proceed with downloading."
+  while ! (whiptail --title "Download Zulu Java" --yes-button "Download and Install" --no-button "Read Terms of Use" --defaultno --yesno "$querytext" 10 80) ; do
+    whiptail --textbox /opt/openhabian/docs/azul-zulu-license.md --scrolltext 27 116


$BASEDIR/docs

functions/java-jre.sh

ThomDietrich · 2018-12-26T13:25:11Z

functions/java-jre.sh

+  cd ${INSTALLROOT}; tar xpzf $FILE
+  cond_redirect update-alternatives --install /usr/bin/java java ${INSTALLROOT}/${JAVA}/bin/java 1083000
+  cond_redirect update-alternatives --install /usr/bin/javac java ${INSTALLROOT}/${JAVA}/bin/javac 1083000
+  rm -f $FILE


Please rearange so that the script

Downloads temporary file, upon success

Extracts archive to temporary location, upon success

Deletes old versions (rm -f $INSTALLROOT/*)

Move temporary to final location

Call update-alternatives

Catching and handling errors is important :)

untested for now

Signed-off-by: Thomas Dietrich <[email protected]>

ThomDietrich · 2018-12-27T20:33:47Z

Thanks ;) @BClark09 @EliasGabrielsson anything else you want to comment on?

ThomDietrich · 2018-12-27T20:35:46Z

functions/java-jre.sh

+  else
+    local JAVA=zulu8.33.0.1-jdk8.0.192-linux_x64
+  fi
+  whiptail --textbox $BASEDIR/includes/azul-zulu-license.md --scrolltext 27 116


"docs"? Please test your code before committing changes

Yes it was working, pointing to docs which is where I had put the license.
I moved it to includes now, that's how I understood your comment.

Do you want me remove Oracle as part of this PR, too ?

untested for now

Signed-off-by: Thomas Dietrich <[email protected]>

… patch-12

mstormi · 2019-01-03T17:43:05Z

it does, it's using the x86 file if not is_arm()
you still want me to refactor that ? Wouldn't make sense to me, that's more lines of code.

EliasGabrielsson · 2019-01-03T23:06:25Z

it does, it's using the x86 file if not is_arm()
you still want me to refactor that ? Wouldn't make sense to me, that's more lines of code.

Compared to the zulu8-embedded software is zulu8 still updated at the apt repository. That means we shall keep the current routine as that ensures updates are pushed out.

So there must be two methods even if it's more line of codes.
I can see if I will get some time next weekend to code on this and help you out with that refactoring / part!

mstormi · 2019-01-04T09:30:38Z

Compared to the zulu8-embedded software is zulu8 still updated at the apt repository.

Did you verify that ?
Just got another reply pointing out they provide no guarantees whatsoever to the community.

ThomDietrich · 2019-01-07T22:52:55Z

@mstormi I just realized that this should be a good tradeoff solution:

curl -s https://www.azul.com/downloads/zulu-embedded  | grep -Eo "http://[a-zA-Z0-9./?=_-]*aarch32hf.tar.gz"

Of course you need to add a simple check to see if the result is an empty string and then this should be fine to use also for future releases

mstormi · 2019-01-09T09:18:27Z

@mstormi I just realized that this should be a good tradeoff solution:

Using the latest code isn't always the best choice as it can be buggy. Using older Java on the other hand (hypothetically whenever a next release comes out but we don't notice) does not do harm. Remember every openHABian user has been installing u152 from the repo with the existing code.
My current code is more conservative but I feel it is the safer bet so prefer to leave it like that.

ThomDietrich · 2019-01-09T10:17:00Z

Using the latest code isn't always the best choice as it can be buggy.

😳 if Azul is confident enough to publish a new release on their webpage, we have to trust in their judgement and follow through. That is the way we follow with every apt repository we install packages from. Be it the deprecated azul repo or any other. Please reconsider.

mstormi · 2019-01-09T18:52:42Z

I'm a bit more conservative there, maybe due to my job where I keep seeing this can often be a problem.
So no I don't want to change that so please don't ask me to. Why not merge my PR and if you really really want to change this then make another followup PR yourself.

EliasGabrielsson · 2019-01-09T23:10:23Z

I also think Thomas's script is the way to go for zulu8-embedded. This reduce code maintenance similar to using an apt repository. As our voluntary resources are few we should devote them to more important stuff. I even think we shall push it even further and call this java installation function from the menu option 02 | Upgrade system as well.

ThomDietrich · 2019-01-10T10:20:12Z

Good point Elias.

@mstormi I understand your concern and your request for a merge. I agree, we should not keep this important PR waiting any longer. I'll give it a last review.

ThomDietrich

Everything seems fine, thanks for this important improvement! 😉 👏

EliasGabrielsson · 2019-01-10T10:39:38Z

A hint for next time please rebase on master instead of merge the code.
I also noticed that the script is broken for x86 installation as the download link is wrong, pointing to zulu-embedded instead of zulu.

ThomDietrich · 2019-01-10T10:47:39Z

Could you clarify? In general it's almost always the better choice to "Squash merge" a PR, especially when it consists of multiple commits that you do not want in the master branch.

About x86: 😕 Could one of you please create a PR?

EliasGabrielsson · 2019-01-11T16:39:15Z

Don't meant to be picky when reviewing stuff but look at this commit message: 6f6154d
Of course could we as maintainers go over everything by hand but I would prefer that the authors of PRs just do a rebase on master and squash theirs' commits.

ThomDietrich · 2019-01-11T21:46:11Z

Ah now I get it. I admit, the history of this branch/PR is a bit messed up and I could have cleaned the commit message. On the other side I have to say that I hate it when contributors rewrite the history of a branch in the middle of the review process. Rewriting git history is evil - doing it during the merge into master is the best time for this ritual.

If I would have to do it again, I'd again choose the squash merge option but actively reduce the commit message to its essence. Agreed?

EliasGabrielsson · 2019-01-11T22:23:00Z

Sounds fair, it's in line with maintainer rules for the organization.
https://github.com/orgs/openhab/teams/maintainers/discussions/1

I know you care for details and this was a miss so lets do better next time.

Signed-off-by: Thomas Dietrich <[email protected]>

mstormi added 5 commits December 19, 2017 22:13

fix changing smbpasswd

3f686e3

Signed-off-by: Markus Storm <[email protected]>

Merge remote-tracking branch 'upstream/master'

bcd113b

Download and install Zulu Embedded from .tar

3bdd4a8

We need to change the installation method of Zulu Java as Azul systems does not maintain Java repos any more.

Download and install Zulu Embedded from .tar

69c10c5

Create azul_zulu_license.md

89387d2

mstormi mentioned this pull request Nov 2, 2018

Zulu install dependency on Ubuntu repo #457

Closed

move setting Java options to openhab2_setup()

2ed71d7

BClark09 reviewed Nov 10, 2018

View reviewed changes

functions/java-jre.sh Outdated Show resolved Hide resolved

functions/java-jre.sh Outdated Show resolved Hide resolved

mstormi added 5 commits November 13, 2018 17:16

don't download to /tmp

2be05b0

due to tmpfs potentially exceeded

latest zulu is 8u192

bfd5c48

java install into /opt/jdk

44a52d2

and use local variables

java link correction

894f5ae

java link corrected

bb8630a

EliasGabrielsson added this to the Image v1.5 milestone Nov 15, 2018

EliasGabrielsson removed this from the Image v1.5 milestone Dec 19, 2018

Merge branch 'master' into patch-12

6a70dad

ThomDietrich requested changes Dec 26, 2018

View reviewed changes

mstormi and others added 5 commits December 27, 2018 16:36

changes as requested by @ThomDietrich

4497fb0

reformat, add source link

3161edb

rearranged java installation to catch errors

d23d03f

untested for now

fix: create TEMPROOT

e01271a

Update java-jre.sh

497900a

Signed-off-by: Thomas Dietrich <[email protected]>

ThomDietrich reviewed Dec 27, 2018

View reviewed changes

license -> docs

8407baf

mstormi and others added 8 commits January 3, 2019 18:35

rearranged java installation to catch errors

8ae1647

untested for now

fix: create TEMPROOT

5df13f1

Update java-jre.sh

4ca4c43

Signed-off-by: Thomas Dietrich <[email protected]>

license -> docs

494345e

Create azul_zulu_license.md

e8deb02

Delete azul_zulu_license.md

506256a

license moved from docs to includes

4388e0e

Merge branch 'patch-12' of https://github.com/mstormi/openhabian into…

4e09e74

… patch-12

remove Oracle java from options

28cbae4

ThomDietrich approved these changes Jan 10, 2019

View reviewed changes

ThomDietrich merged commit 6f6154d into openhab:master Jan 10, 2019

ThomDietrich mentioned this pull request Jan 10, 2019

During initial setup: "java_zulu_embedded: command not found" #508

Closed

ThomDietrich pushed a commit that referenced this pull request Jan 11, 2019

Temporarly revert #459

6b64c90

Signed-off-by: Thomas Dietrich <[email protected]>

ThomDietrich mentioned this pull request Jan 12, 2019

Temporarly revert #459 #516

Merged

EliasGabrielsson pushed a commit that referenced this pull request Jan 12, 2019

Temporarly revert #459 (#516)

8f928e9

Signed-off-by: Thomas Dietrich <[email protected]>

mstormi deleted the patch-12 branch May 8, 2019 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Download and install Zulu Embedded Java from .tar #459

Download and install Zulu Embedded Java from .tar #459

mstormi commented Nov 2, 2018

mstormi commented Nov 2, 2018

BClark09 Nov 10, 2018

mstormi Nov 13, 2018

BClark09 Nov 10, 2018

mstormi Nov 13, 2018 •

edited

Loading

BClark09 left a comment

EliasGabrielsson commented Nov 13, 2018

BClark09 commented Dec 21, 2018

ThomDietrich left a comment

ThomDietrich Dec 26, 2018

ThomDietrich Dec 26, 2018

ThomDietrich Dec 26, 2018 •

edited

Loading

ThomDietrich Dec 26, 2018

ThomDietrich commented Dec 27, 2018

ThomDietrich Dec 27, 2018

mstormi Dec 29, 2018 •

edited

Loading

mstormi commented Jan 3, 2019 •

edited

Loading

EliasGabrielsson commented Jan 3, 2019

mstormi commented Jan 4, 2019 •

edited

Loading

ThomDietrich commented Jan 7, 2019

mstormi commented Jan 9, 2019 •

edited

Loading

ThomDietrich commented Jan 9, 2019

mstormi commented Jan 9, 2019

EliasGabrielsson commented Jan 9, 2019

ThomDietrich commented Jan 10, 2019

ThomDietrich left a comment

EliasGabrielsson commented Jan 10, 2019

ThomDietrich commented Jan 10, 2019 •

edited

Loading

EliasGabrielsson commented Jan 11, 2019

ThomDietrich commented Jan 11, 2019 •

edited

Loading

EliasGabrielsson commented Jan 11, 2019

Download and install Zulu Embedded Java from .tar #459

Download and install Zulu Embedded Java from .tar #459

Conversation

mstormi commented Nov 2, 2018

mstormi commented Nov 2, 2018

BClark09 Nov 10, 2018

Choose a reason for hiding this comment

mstormi Nov 13, 2018

Choose a reason for hiding this comment

BClark09 Nov 10, 2018

Choose a reason for hiding this comment

mstormi Nov 13, 2018 • edited Loading

Choose a reason for hiding this comment

BClark09 left a comment

Choose a reason for hiding this comment

EliasGabrielsson commented Nov 13, 2018

BClark09 commented Dec 21, 2018

ThomDietrich left a comment

Choose a reason for hiding this comment

ThomDietrich Dec 26, 2018

Choose a reason for hiding this comment

ThomDietrich Dec 26, 2018

Choose a reason for hiding this comment

ThomDietrich Dec 26, 2018 • edited Loading

Choose a reason for hiding this comment

ThomDietrich Dec 26, 2018

Choose a reason for hiding this comment

ThomDietrich commented Dec 27, 2018

ThomDietrich Dec 27, 2018

Choose a reason for hiding this comment

mstormi Dec 29, 2018 • edited Loading

Choose a reason for hiding this comment

mstormi commented Jan 3, 2019 • edited Loading

EliasGabrielsson commented Jan 3, 2019

mstormi commented Jan 4, 2019 • edited Loading

ThomDietrich commented Jan 7, 2019

mstormi commented Jan 9, 2019 • edited Loading

ThomDietrich commented Jan 9, 2019

mstormi commented Jan 9, 2019

EliasGabrielsson commented Jan 9, 2019

ThomDietrich commented Jan 10, 2019

ThomDietrich left a comment

Choose a reason for hiding this comment

EliasGabrielsson commented Jan 10, 2019

ThomDietrich commented Jan 10, 2019 • edited Loading

EliasGabrielsson commented Jan 11, 2019

ThomDietrich commented Jan 11, 2019 • edited Loading

EliasGabrielsson commented Jan 11, 2019

mstormi Nov 13, 2018 •

edited

Loading

ThomDietrich Dec 26, 2018 •

edited

Loading

mstormi Dec 29, 2018 •

edited

Loading

mstormi commented Jan 3, 2019 •

edited

Loading

mstormi commented Jan 4, 2019 •

edited

Loading

mstormi commented Jan 9, 2019 •

edited

Loading

ThomDietrich commented Jan 10, 2019 •

edited

Loading

ThomDietrich commented Jan 11, 2019 •

edited

Loading