Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Added OpenPaths presence detection binding #7

Closed
wants to merge 5 commits into from
Closed

Added OpenPaths presence detection binding #7

wants to merge 5 commits into from

Conversation

sumnerboy12
Copy link
Contributor

IGNORE THIS PULL REQUEST - DON'T KNOW HOW TO DELETE IT MYSELF - PERHAPS YOU CAN FROM MASTER?

@sumnerboy12
Copy link
Contributor Author

Also added PiFace watchdog stuff - not sure how to separate into two pull requests, or if this is correct?! Sorry - very new to this GIT stuff...

@kaikreuzer
Copy link
Member

I am also new to the GitHub stuff, so I cannot really tell you how to do it right - but nonetheless, I think the piface binding change should be a separate pull request - could you remove these commits from the request, please?

@cyclingengineer
Copy link
Contributor

This seems to be the solution -
http://stackoverflow.com/questions/11721219/selecting-commits-to-send-in-a-pull-request

Cherry pick your commits you want over to a new branch and then pull
request that branch. You'll need a separate branch for each feature/bug fix.

Thanks,
Paul

On 27 September 2013 07:08, kaikreuzer [email protected] wrote:

I am also new to the GitHub stuff, so I cannot really tell you how to do
it right - but nonetheless, I think the piface binding change should be a
separate pull request - could you remove these commits from the request,
please?


Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-25224874
.

@sumnerboy12
Copy link
Contributor Author

Ok - I have spent the last 2 hours trying to get my head around this stuff. I gotta say it is far from intuitive! I think I have created two new pull requests, each for the two separate bits of work - OpenPaths binding and PiFace watchdog enhancement. Let me know if there are any problems. I wasn't able to delete/remove the initial pull request, or edit it - perhaps you can do that from the master branch?

@kaikreuzer kaikreuzer closed this Sep 28, 2013
dereulenspiegel pushed a commit to dereulenspiegel/openhab that referenced this pull request Jan 13, 2014
Fix thermostatplus reading & increase debug info M message
digitaldan pushed a commit to digitaldan/openhab that referenced this pull request Dec 12, 2014
@mstormi mstormi mentioned this pull request Dec 5, 2015
cdjackson added a commit that referenced this pull request Dec 16, 2015
digitaldan pushed a commit to digitaldan/openhab that referenced this pull request Dec 17, 2015
cdjackson added a commit that referenced this pull request Jan 6, 2016
Update FGS-222 param #7 description to match Fibaro docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants