This repository has been archived by the owner on May 17, 2021. It is now read-only.
[fatekplc] Added serial port support #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
force-pushed
the
fix-5871
branch
3 times, most recently
from
adce705 to
052eff1
Compare
slawekjaranowski
changed the title
Signed-off-by: Slawomir Jaranowski <[email protected]>
slawekjaranowski
force-pushed
the
fix-5871
branch
from
052eff1 to
0722944
Compare
|
Started working after upgrade openhab M2 to M4 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/failed-build-pr-for-openhab1-addons/85410/4 |
|
I kindly ask about review @openhab/1-x-add-ons-maintainers |
|
@Marcin-st please clarify your statement. Are you saying that the problem you filed in #5871 is no longer occurring for you? If it is not, please close that ticket. @slawekjaranowski if that problem is no longer occurring, this PR is not needed? |
|
The issue #5871 report that fatekplc binding doesn't have support to communicate by serial line / serial port with plc. This PR add such possibility, so extends functionality and is needed. |
|
During test we talked with @Marcin-st on https://community.openhab.org/t/fatek-binding-to-use-usb-cabel/74509 So text "Started working after upgrade openhab M2 to M4" means that this PR start morking. |
|
Confirm. Fatek now is working with Serial-USB cabel. |
kaikreuzer
changed the title
Efus10n
added a commit
to Efus10n/openhab1-addons
that referenced
this pull request
Jan 1, 2020
* moved legacy bindings to the correct feature (openhab#5893) Signed-off-by: Kai Kreuzer <[email protected]> * removed Sen.se persistence service (openhab#5850) Signed-off-by: Kai Kreuzer <[email protected]> * removed sense persistence service from distro pom (openhab#5894) Signed-off-by: Kai Kreuzer <[email protected]> * Update README.md (openhab#5898) Add FritzBox TR064 Item configuration for events for active calls, present in the source code of the binding since 20.12.2015 Signed-off-by: Jan Hendriks <[email protected]> * Fix Serial binding where serial commands in rapid succession were not recognized (openhab#5891) Signed-off-by: Marek Halmo <[email protected]> * updated product links (openhab#5901) Signed-off-by: Kai Kreuzer <[email protected]> * Typo lead to confusing instructions (openhab#5896) The address in the first example is 0x21, but the explenation under it statet the address as 0x20. The second example shows the right way * Update README.md adding FB 6490 (openhab#5900) Added Fritz Box 6490 Cable (v7.02) as working and supported model. Signed-off-by: dirkbe <[email protected]> * - Fixing a minor TYPO (openhab#5878) - Adding that no `things` file configuration required Signed-off-by: Soren Thorsen <[email protected]> * Update org.apache.http dependencies (openhab#5887) Signed-off-by: Christoph Weitkamp <[email protected]> * Fix empty reactor summary on newer Maven versions (openhab#5885) On newer Maven versions the reactor summary also contains the project name and version so the regexp needs to be adjusted for this. Also make sure grep treats binary data as text (-aE switch) so the pipe doesn't choke on this. Signed-off-by: Wouter Born <[email protected]> * Fixed POM XML Shema Definition path (openhab#5903) Signed-off-by: Christoph Weitkamp <[email protected]> * moved networkupstools to legacy addons (openhab#5904) Signed-off-by: Kai Kreuzer <[email protected]> * [fritzboxtr0641] Improve docs (openhab#5908) * Translate log message * Wifi => Wi-Fi, see https://en.wikipedia.org/wiki/Wi-Fi * Use capital letter after bullet point Signed-off-by: mueller-ma <[email protected]> * [KNX.Test] workaround for timezone in KNXCoreTypeMapperTest (openhab#5912) Signed-off-by: Slawomir Jaranowski <[email protected]> * Added utime (openhab#5910) Signed-off-by: Christoph Weitkamp <[email protected]> * Fixed restriction on special characters in URLs (openhab#5868) Escaping special characters in URLs allows usage of calendar-ids with special characters, e.g. private-home --> private%2Dhome Signed-off-by: CSchlipp <[email protected]> * Novelan heatpump: Add output signals and additional state variables as items, add missing heatpump states (openhab#5883) Signed-off-by: Andre Heßling <[email protected]> * little Mistake (openhab#5909) * [fatekplc] Serial port support (openhab#5877) Signed-off-by: Slawomir Jaranowski <[email protected]> * Update README.md with improved config info. (openhab#5841) * fixed typo * [swegon] Added throttle support (openhab#5685) Signed-off-by: Pauli Anttila <[email protected]> * [oem] throttle support (openhab#5684) Signed-off-by: Pauli Anttila <[email protected]> * Anel binding: mask pwd in log entries; issue openhab#5716 (openhab#5828) * Use stock OLA from OS by default (openhab#5696) * [GPIO] Fixes debounce Item state out of sync (openhab#5729) (openhab#5730) * Fixes GPIO Binding Item state out of sync even with debounce set. Fixes openhab#5729 Signed-off-by: Ingo Schuck <[email protected]> (github: oktett-8) * fixed compilation error (openhab#5919) Signed-off-by: Kai Kreuzer <[email protected]> * Update README.md (openhab#5920) Tested myself on FB 7580 * [Davis] Formatting changes for README (openhab#5794) * [Daikin] Formatting changes for README (openhab#5793) * Update README.md changed pre to ``` for better readability on openhab.org * Update README.md Added empty line above code fences * [Diyonxbee] Formatting changes for README (openhab#5796) * [CalDAV-Command] Readability enhancements for README (openhab#5789) * Update README.md * [Cups] Update README with better sendCommand alternative (openhab#5792) * Fixed minor typo (openhab#5780) * fixed typo * [CalDAV-Personal] Minor cleanup for README (openhab#5790) * Update README.md * [SNMP] Update README.md for the version property (openhab#5779) * Update README.me according to openhab#2426, the binding supports at least also version v2c. I tested it to make a COUNTER64 OID work (https://community.openhab.org/t/synology-disk-usage-and-snmp-binding/65869) I wasn't able to test SET * Update bundles/binding/org.openhab.binding.snmp/README.md Co-Authored-By: on4tux <[email protected]> * Update README.md * [http] Fixed NPE while executing background thread (openhab#5718) * Don't execute when the binding is shutting down. * Update README.md (openhab#5614) * [squeezebox action] linter errors pass 2 (openhab#5476) Signed-off-by: Brad Gilmer <[email protected]> * [unleash-maven-plugin] Preparation for next development cycle. * update OpenWebNet link, current link is dead (openhab#5921) https://developer.legrand.com/uploads/2019/12/OWN_Intro_ENG.pdf Co-authored-by: Kai Kreuzer <[email protected]> Co-authored-by: Jan Hendriks <[email protected]> Co-authored-by: marekhalmo <[email protected]> Co-authored-by: bitDealer <[email protected]> Co-authored-by: dirkbe <[email protected]> Co-authored-by: Søren Thorsen <[email protected]> Co-authored-by: Christoph Weitkamp <[email protected]> Co-authored-by: Wouter Born <[email protected]> Co-authored-by: mueller-ma <[email protected]> Co-authored-by: Slawomir Jaranowski <[email protected]> Co-authored-by: CSchlipp <[email protected]> Co-authored-by: André Heßling <[email protected]> Co-authored-by: Arut42 <[email protected]> Co-authored-by: Amos Kittelson <[email protected]> Co-authored-by: pali <[email protected]> Co-authored-by: paphko <[email protected]> Co-authored-by: Peter Newman <[email protected]> Co-authored-by: oktett-8 <[email protected]> Co-authored-by: msimat <[email protected]> Co-authored-by: Sem <[email protected]> Co-authored-by: Michael Rumpf <[email protected]> Co-authored-by: on4tux <[email protected]> Co-authored-by: Chris Carman <[email protected]> Co-authored-by: aurelio1 <[email protected]> Co-authored-by: Brad Gilmer <[email protected]> Co-authored-by: Thomas Manson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #5871