This repository has been archived by the owner on May 17, 2021. It is now read-only.
[jdbc] Fixed sqltype.table* options #5820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/wrong-time-zone-with-jdbc-persistence-and-postgres/52938/4 |
Options `sqltype.tablePrimaryKey` and `sqltype.tablePrimaryValue` were not read correctly. They were treated as yet another item type which didn't match their use in the code. Also added debug log of sql query similar to other functions.
skazi0
force-pushed
the
jdbc_sqltype_fix
branch
from
da424e1 to
b5ae241
Compare
9037568
suggested changes
Feb 26, 2019
|
LGTM too. Thank You @skazi0! |
|
Thanks, @skazi0 ! |
kaikreuzer
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options
sqltype.tablePrimaryKeyandsqltype.tablePrimaryValuewere not readcorrectly. They were treated as yet another item type which didn't match their use
in the code.
Also added debug log of sql query similar to other functions.
Second commit is just a "copy/paste" bug fix.