This repository has been archived by the owner on May 17, 2021. It is now read-only.
[pilight] Added pilight feature #5769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeroen Idserda <[email protected]>
Signed-off-by: Jeroen Idserda <[email protected]>
9037568
suggested changes
Jan 16, 2019
| @@ -108,6 +108,7 @@ | |||
| <artifact><file>src/main/resources/conf/panasonictv.cfg</file><type>cfg</type><classifier>panasonictv</classifier></artifact> | |||
| <artifact><file>src/main/resources/conf/pebble.cfg</file><type>cfg</type><classifier>pebble</classifier></artifact> | |||
| <artifact><file>src/main/resources/conf/piface.cfg</file><type>cfg</type><classifier>piface</classifier></artifact> | |||
| <artifact><file>src/main/resources/conf/pilight.cfg</file><type>cfg</type><classifier>piface</classifier></artifact> | |||
There was a problem hiding this comment.
This appears to be causing the build to fail. Copy/Paste error?
13:40:15 [ERROR] Failed to execute goal org.codehaus.mojo:build-helper-maven-plugin:1.9.1:attach-artifact (attach-artifact) on project openhab-addons-external: The artifact with same type and classifier: cfg:piface is used more than once. -> [Help 1]
| # Port of the pilight daemon. You must explicitly configure the port in pilight or otherwise a random port will be used and the binding will not be able to connect. | ||
| # <instance>.port=<port> | ||
| # | ||
| # Optional delay (in millisecond) between consecutive commands. Recommended value without band pass filter: 1000. Recommended value with band pass filter: somewhere between 200-500 |
|
Thanks! Changed the classifier and the typo. Build is succeeding now. |
|
Thanks, @idserda ! |
kaikreuzer
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the pilight binding to the list of features so it can be easily installed. This fixes #5742 .