Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

[Telegram] Support for formatted messages #5765

Merged
merged 5 commits into from
Jan 25, 2019

Conversation

thorstenbe
Copy link
Contributor

@thorstenbe thorstenbe commented Jan 11, 2019

This pull requests adds the ability to write messages that contain markdown or html tags, see https://core.telegram.org/bots/api#markdown-style.
It is configurable if a bot should use formatted messages in the telegram.cfg. This pull request is inspired by #5490 but since the other pull request is stale I started a complete rewrite.

Copy link
Contributor

@9037568 9037568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one inline comment, this looks good to me.

Copy link
Contributor

@9037568 9037568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thorstenbe
Copy link
Contributor Author

Do I have to do anything that this pull request gets merged? (Sorry for the dumb question but it is my first one)

@9037568
Copy link
Contributor

9037568 commented Jan 20, 2019

Nope, you're done. This'll get merged soon.

@9037568
Copy link
Contributor

9037568 commented Jan 25, 2019

Thanks, @thorstenbe !

@9037568 9037568 merged commit d75a360 into openhab:master Jan 25, 2019
@9037568 9037568 added this to the 1.14.0 milestone Jan 25, 2019
@thorstenbe thorstenbe deleted the telegram-markdown-support branch February 3, 2019 12:58
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/sending-telegram-messages-with-text-formatting/76496/2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants