This repository has been archived by the owner on May 17, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Telegram] Support for formatted messages #5765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9037568
suggested changes
Jan 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the one inline comment, this looks good to me.
...ction.telegram/src/main/java/org/openhab/action/telegram/internal/TelegramActionService.java
Outdated
Show resolved
Hide resolved
9037568
reviewed
Jan 16, 2019
9037568
reviewed
Jan 16, 2019
...ction.telegram/src/main/java/org/openhab/action/telegram/internal/TelegramActionService.java
Outdated
Show resolved
Hide resolved
9037568
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Do I have to do anything that this pull request gets merged? (Sorry for the dumb question but it is my first one) |
Nope, you're done. This'll get merged soon. |
Thanks, @thorstenbe ! |
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/sending-telegram-messages-with-text-formatting/76496/2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds the ability to write messages that contain markdown or html tags, see https://core.telegram.org/bots/api#markdown-style.
It is configurable if a bot should use formatted messages in the
telegram.cfg
. This pull request is inspired by #5490 but since the other pull request is stale I started a complete rewrite.