Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

[Weather] Add support for APIXU and Weatherbit as weather provider #5750

Merged
merged 12 commits into from
Jan 12, 2019
Merged

[Weather] Add support for APIXU and Weatherbit as weather provider #5750

merged 12 commits into from
Jan 12, 2019

Conversation

jmahmens
Copy link
Contributor

@jmahmens jmahmens commented Jan 3, 2019 •
edited
Loading

I 've added two new free provider for weather forecast.

Both provides a free forecast. Only ApiKey must be created like all other provider.
I will try to create openhab2-addons for these both in the next day's.

@9037568
Copy link
Contributor

9037568 commented Jan 5, 2019

First, @jmahmens, thank you for your contribution. However, I'm not sure it makes sense to add new functionality to the OH1 platform, especially when you plan to create new matching OH2 addons.

@kaikreuzer what do you think?

[Weather] Add two new Provider APIXU and Weatherbit.
686f3d3 
Resolve merge conflicts from master after rebase.
[Weather] Add two new Provider APIXU and Weatherbit. openhab#5750
9941680 
Remove unused responsecode for Weatherbit provider.
@jmahmens
Copy link
Contributor Author

jmahmens commented Jan 5, 2019

First, @jmahmens, thank you for your contribution. However, I'm not sure it makes sense to add new functionality to the OH1 platform, especially when you plan to create new matching OH2 addons.

@kaikreuzer what do you think?

Well, i think this is a good startingpoint for development of new oh2 addons.
I do this additon of new providers because yahoo was dropped and Wunderground dosn't support free use anymore. OpenWeatherMap provides no free 'daily' forecast, only 3hourly. DarkSky (forecastio), WorldWeaterOnline provides only a limited free forecast.
So this both APIXU and Weatherbit are a chance for those OH1 user have only change their provider and not the whole System.

@jmahmens jmahmens closed this Jan 5, 2019
@jmahmens jmahmens reopened this Jan 5, 2019
@jmahmens
Copy link
Contributor Author

jmahmens commented Jan 5, 2019

Sorry closed accidently

@kaikreuzer
Copy link
Member

@kaikreuzer what do you think?

As @jmahmens did the work, I think it is fair to merge it. But in general, I very much agree that new features should rather be done directly as OH2 bindings.

9037568
9037568 suggested changes Jan 6, 2019
View reviewed changes
Copy link
Contributor

@9037568 9037568 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to addressing the inline comments, please run the source through the Eclipse formatter.

bundles/binding/org.openhab.binding.weather/README.md Outdated Show resolved Hide resolved
...her/src/main/java/org/openhab/binding/weather/internal/provider/AbstractWeatherProvider.java Outdated Show resolved Hide resolved
...her/src/main/java/org/openhab/binding/weather/internal/provider/AbstractWeatherProvider.java Outdated Show resolved Hide resolved
...nding.weather/src/main/java/org/openhab/binding/weather/internal/provider/ApiXuProvider.java Outdated Show resolved Hide resolved
...nding.weather/src/main/java/org/openhab/binding/weather/internal/provider/ApiXuProvider.java Outdated Show resolved Hide resolved
...src/main/java/org/openhab/binding/weather/internal/converter/property/UnixDateConverter.java Show resolved Hide resolved
...nhab.binding.weather/src/main/java/org/openhab/binding/weather/internal/model/Condition.java Show resolved Hide resolved
...her/src/main/java/org/openhab/binding/weather/internal/provider/AbstractWeatherProvider.java Show resolved Hide resolved
...her/src/main/java/org/openhab/binding/weather/internal/provider/AbstractWeatherProvider.java Show resolved Hide resolved
...ther/src/main/java/org/openhab/binding/weather/internal/provider/WeatherProviderFactory.java Outdated Show resolved Hide resolved
@jmahmens
Merge branch 'master' into master
fa699b1
@jmahmens
Update README.md
e054579 
Resolve review finding.
@jmahmens
Update WeatherConfig.java
920cbca 
Resolve review findings.
@jmahmens
Update WeatherConfig.java
3333258 
Resolve review findings
@jmahmens
Update UnixDateConverter.java
3f0bdb8 
Resolve review findings
@jmahmens
Update ApiXuProvider.java
3dfc7df 
Resolve review findings
@jmahmens
Update WeatherProviderFactory.java
2b408d5 
Resolve review findings
@jmahmens
Update WeatherbitProvider.java
9a2a997 
Resolve review findings
@jmahmens
Update WeatherProviderFactory.java
7448882 
Resolve review findings
@jmahmens
Copy link
Contributor Author

jmahmens commented Jan 9, 2019

I've tryed to resolve the review findings.
Please do a new rewiev.

@9037568 9037568 added this to the 1.14.0 milestone Jan 12, 2019
@9037568
Copy link
Contributor

9037568 commented Jan 12, 2019

Thanks, @jmahmens !

@9037568 9037568 merged commit b6aaf4a into openhab:master Jan 12, 2019
@jmahmens
Copy link
Contributor Author

Thanks for mergin this. I will now try the next step. But one question.
Should I try develop an OH2 binding or an eclipse.
A good template for these two new provider are die existing Wunderground and openweathermap eclipse bindings.

@kaikreuzer
Copy link
Member

@jmahmens Please go for adding them to the openhab2-addons repo - thanks!

@wborn wborn changed the title [Weather] Add two new Provider APIXU and Weatherbit. [Weather] Add two new Provider APIXU and Weatherbit Dec 8, 2019
@wborn wborn changed the title [Weather] Add two new Provider APIXU and Weatherbit [Weather] Add support for APIXU and Weatherbit as weather provider Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@9037568 9037568 9037568 requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jmahmens @9037568 @kaikreuzer