Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Update FGS-222 param #7 description to match Fibaro docs #3710

Merged
merged 2 commits into from
Jan 6, 2016
Merged

Update FGS-222 param #7 description to match Fibaro docs #3710

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f2bf0f
Update FGS-222 param #7 description to match Fibaro docs
mstormi Jan 5, 2016
3dcd14f
Update param #7 of fgs-222
mstormi Jan 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions bundles/binding/org.openhab.binding.zwave/database/fibaro/fgs222.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,20 +113,23 @@
<Type>list</Type>
<Default>1</Default>
<Size>1</Size>
<Label lang="en">Control key #2 behaviour</Label>
<Label lang="en">Sending commands to control devices assigned to 2-nd association group (key no. 2)</Label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is too long for a label? It might screw up the UI. What's wrong with the short label that is already there?

<Item>
<Value>0</Value>
<Label lang="en">Device status is not checked</Label>
<Label lang="en">Commands are sent when device is turned on and </Label>
</Item>
<Item>
<Value>1</Value>
<Label lang="en">Device status is checked</Label>
<Label lang="en">![CDATA[Commands are sent when device is turned off. Enabling device does not send control commands.<BR />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, I think this is too long for a label. I'm also not sure it's a good idea to have HTML in the label like this - it's probably best to keep the longer HTML descriptions in the help?

Double-clicking key sends 'turn on' command, dimmers memorize the last saved state (e.g. 50% brightness).]]</Label>
</Item>
<Help lang="en">Key no.2 is not represented by any physical device - only
devices in the association list.
This functionality prevents of lack of reaction on pressing key no.2
through polling devices
from association list one by one and checking their actual statuses.</Help>
<Item>
<Value>2</Value>
<Label lang="en">![CDATA[Commands are sent when device is turned off. Enabling device does not send control commands.<BR />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above regarding length and HTML in the label

Double-clicking key sends 'turn on' command and dimmers are set to 100% brightness.]]</Label>
</Item>
<Help lang="en">![CDATA[NOTE: Parameter 15 value must be set to 1 to work properly.<BR />
This activates the double-click functionality - dimmer/roller shutter control.]]</Help>
</Parameter>

<Parameter>
Expand Down