Skip to content
This repository was archived by the owner on May 17, 2021. It is now read-only.

Fix issue #1845, try 2 #2540

Merged
merged 1 commit into from
May 4, 2015
Merged

Fix issue #1845, try 2 #2540

merged 1 commit into from
May 4, 2015

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 4, 2015

Clean Commit. Old PR #2445 was messed up while rebasing.

@@ -525,7 +528,7 @@ private void handleEventType(MonitorEvent event, String bindingType) {
.getItemNamesForType(bindingType)) {
Class<? extends Item> itemType = provider
.getItemType(itemName);

//logger.info("Processing {} {}", itemName, itemType);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please uncomment und decrease level to DEBUG or TRACE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed completely. It was not included in my original commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me as well …

@teichsta
Copy link
Member

teichsta commented May 4, 2015

Hi @J-N-K thanks for the clean-up. Please find my review comments inline. Best, Thomas E.-E.

@teichsta teichsta added this to the 1.7.0 milestone May 4, 2015
Following teichstas comments
teichsta added a commit that referenced this pull request May 4, 2015
@teichsta teichsta merged commit a4f3fce into openhab:master May 4, 2015
@buildhive
Copy link

openhab » openhab #2890 SUCCESS
This pull request looks good
(what's this?)

@J-N-K J-N-K deleted the fix-fritzbox-exception branch December 17, 2016 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants