Query nodes for the number of groups supported. This Fixes #1452. #1459
Conversation
|
Nice! I’d not come across this message - I took the iteration through the groups methods from OZW - not sure why they didn’t do this! Let’s not merge just yet though. I’d like to have a play for a day or two, and I have one comment (which I’ll comment in the code). Cheers |
| @@ -56,6 +56,9 @@ | |||
|
|
|||
| @XStreamOmitField | |||
| private AssociationGroup pendingAssociation = null; | |||
|
|
|||
| @XStreamOmitField | |||
There was a problem hiding this comment.
Why omit this member from the XML?
Given that the number of associations don't change, this should I think be saved into the XML and then we could avoid doing the 'get groupings report' if the value isn't 0.
There was a problem hiding this comment.
Yep, I did that without even thinking about it, Ill omit it.
|
openhab » openhab #1219 SUCCESS |
|
openhab » openhab #1221 SUCCESS |
|
pls just give me sign, when this PR is ready to merge. Thanks, Thomas E.-E. |
|
Hey Thomas - I would say this is good to merge... |
Query nodes for the number of groups supported. This Fixes #1452.
…nhab#1459) - Fix setColor(black) action to trigger OFF command for RGB devices Signed-off-by: Pepijn de Geus <[email protected]> (github: pdegeus)
I would like @cdjackson to sign off on this one before it gets merged please. The zwave binding queries devices for groups until the device reports back that a group has zero max associations. Some devices like the Honeywell TH8320ZW thermostat simply do not reply at all when queried on a non existent group. This change queries the node for the number of groups first, then queries each one. I checked with the open zwave code, and while they have logic to do it both ways, afaik, only this way is actually used.