XBMC - Add functionality to show and adjust XBMC volume through an item of type... #1367
Conversation
|
openhab » openhab #1100 FAILURE |
|
Apparently this only was a failure because it received an error sending out the email after finishing. At least, that's my conclusion :) |
|
openhab » openhab #1102 FAILURE |
|
openhab » openhab #1103 SUCCESS |
| @@ -280,6 +296,8 @@ protected void internalReceiveCommand(String itemName, Command command) { | |||
| connector.showNotification("openHAB", command.toString()); | |||
| if (property.equals("System.Shutdown") && command == OnOffType.OFF) | |||
| connector.systemShutdown(); | |||
| if (property.equals("Application.Volume")) | |||
| connector.applicationSetVolume(command.toString()); | |||
There was a problem hiding this comment.
please use "else if" since only one option can be valid at a time
|
Hi @avdleeuw , thanks for this contribution. Please find my Review comments inline. Best, Thomas E.-E. |
…ype Dimmer. Including corrections after review comments.
|
Hi @teichsta , I've corrected the code where applicable. Hope this will be fine now! |
|
openhab » openhab #1106 UNSTABLE |
|
The UNSTABLE build from Buildhive is caused by a timestamp issue in the KNX binding which isn't touched by this PR. |
XBMC - Add functionality to show and adjust XBMC volume through an item of type...
Thanks, Ard |
... Dimmer.