This repository has been archived by the owner on May 17, 2021. It is now read-only.
[mail (and possibly other bindings)] Circular reference error at startup #4604
Comments
|
I've had this happen with the compat1x too.
Latest snapshot build installed after deleting the cache and tmp folders. |
|
Including a full stack trace. |
|
Same here :/ |
|
I pared down my bindings to just mail, then turned on ESH debugging. This is the full log from startup until it starts loading items, rules, etc. @kaikreuzer Any thoughts on what change(s) might've introduced this? |
|
@mhilbush Can you say since when you experience this? I don't have any clear idea what change could have caused this. The closest change to this was eclipse-archived/smarthome#1810 early July, which actually fixed circular deps issues, but maybe it introduced a new one in the compat layer... |
|
@kaikreuzer Thanks. For me it started in OH2 build 454, which I think is the build that picked up the new ESH stable? I suppose this could be just a coincidence. I had installed numerous builds prior to 454, none of which exhibited this problem. The first forum post was Aug 24, which also seems to align with build 454. Didn't builds prior to 454 have the ESH build from 8/3? If so, wouldn't that ESH build have had the 1810 fix? |
|
This error happens more often if I want to use multiple 1x compat bindings. So all seems to work well if I use only 2.0 ready bindings but it starts failing if I use 1x compat bindings. But that's only my feeling :) Thanks for checking this out!! |
Yes, they should have had this fix already. So it is probably unrelated and some other change must have caused this. Let's hope that I first find the time and then find the cause and a fix! |
|
I'm seeing this error in my new setup (#456) using bindings intertechno and HTTP. |
|
Full stack trace that refers to eventbridge. |
|
As the problem occurs throughout any addon that uses the compat layer, the most likely reason is a problem in the compat1x bundle then. From the timing, I would assume that it is due to https://github.com/kaikreuzer/openhab-core/pull/53. As the exceptions really do not tell much about which services create the circular dependency, I have created https://github.com/kaikreuzer/openhab-core/pull/58 as a wild guess - this was a service that implemented an interface of the compat layer, while requiring an ESH service. With my change, it now only refers to ESH services/interfaces. Let's touch wood and see if it makes a difference... Tomorrows distro should contain this PR already. |
|
Very good. I'll install tonight's build in the morning and report back results. |
|
Should be in build https://openhab.ci.cloudbees.com/job/openHAB-Distribution/460/ once it is through. |
|
Unfortunately, I still have errors. (Note the time stamp is wrong, for some reason my logs are 12 hours behind the actual time. It's always been this way and i've never bothered to look into fixing it) |
|
What exactly do I have to do to reproduce it? |
|
I've had the same problems with "Circular reference detected". Build 460 solved my problems. For now at least. I'll keep my eyes open. |
|
I installed build 460. I install the build by first removing openhab/runtime, openhab/userdata/cache, and openhab/userdata/tmp, then laying down the new distro. The behavior has changed. It's still complaining about the circ ref for mail. But it's now throwing other exceptions. My config is very simple. I have an addons.cfg containing the following. I've reduced this down to the most minimal configuration. There are no items, rules, persistence, etc. files. I have ESH at DEBUG log level. Attached is the log file showing startup and shutdown. And here is the list of installed bundles. If there's something else I can do or provide, let me know. |
|
Pity, it seems to have been a too wild guess then... I can reproduce it, will try to further analyse it. |
|
As soon as build 461 finishes building, I'll try it out and report back. @kaikreuzer Thanks! |
|
Don't thank me as long as it isn't fixed... I now get a Different than before, but still not perfect :-( |
|
I'm still seeing a bunch of these, too. |
|
These are unrelated, but good to know as well. Are you running on Linux? |
|
Your javasound messages will disappear with https://github.com/kaikreuzer/openhab-core/pull/60 again. I did a couple of restarts and now it all looks good on my end. Do you still see any circular dependency problems? |
|
Yes. Ubuntu 16.04 LTS. |
|
Latest build 462 does not show the javasound exceptions anymore. Can anyone else confirm? |
|
Confirmed on my minimal configuration. I'll test on a more robust config in my test environment next. |
|
I installed another binding (caldav-command) and get this: EDIT: Maybe this is related to another problem. After some restarts with caldav binding I dont see this error again. On the other hand the caldav binding does nothing. :/ No log output, nothing. |
|
I have strange behaviour also, started the same time as this problems. I now get 1 error: with a whole stacktrace. No other errors, but only some work. zwave and systeminfo are downloaded and installed from previous run. And in paperui showing installed. But on this run, nothing indicates it is starting or running. No channels, items, or info warnings from these bindings. If you want more info, please ask. |
|
Installed build #462 |
|
When trying to use only zwave it gives the following errors on first install: On the next run, I see nothing anymore from zwave in the logs... PS: this error seems to repeat for every zwave device xml file embedded in the binding. |
|
I'm running build 462 in two environments -- my test environment and one of my prod environments. Both are running well with no presence of any of the previous errors. That zwave error, assuming you're running the 2.0 version of the zwave binding, may be unrelated. You might want to open that as an issue in the zwave repo, or post on the forum, for Chris to assess. As for the error in the weather binding, I wonder if that is an error in the weather binding itself, which might be manifesting itself now because bindingChanged() in WeatherBinding.java is being called now when it wasn't before. This is just a guess on my part. You might want to open that as a separate issue, as well. @kaikreuzer Your call on when you want to close this issue. |
|
@kaikreuzer Apparently the internal database was wiped... I need to configure all again. But at least the binding is working again. Maybe going to config them all in the items file now, easier to backup :-) |
|
Mh I think something is still broken. Before build 46x I was able to get the caldav binding to work if I use only this specific binding. If I added another binding (exec) I got the circular ref error from this issue. But as of now it stops working at all. It doesn't matter if it is used standalone or alongside other bindings. It disappears completely from the logs. My test environment is cleaned by reinstalled via |
|
So, it would seem this is not fully sorted out yet.
|
|
Thank you all for testing. From what I read is that the circular dependency issue seems to be solved - all other issues are likely to be something else and should be analysed individually (in their own issue). |
|
It seems to me that this fix is related to all other issues, because before 46x this bindings sometimes work (if there were no circular ref error), but after 46x they don't work at all. Maybe this fix introduced another bug!? |
No, because this fix only reverted a previous change that caused the circular dependency issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm seeing this error during consistently during startup of OH2 for the OH1 mail binding. I'm not sure if this should be posted here, or in another repo, since it's unclear where the root cause is.
It was resulting in this error when calling sendMail from within a rule.
At least one other occurrence has been reported here:
https://community.openhab.org/t/circular-reference-within-1x-bindings
This started to occur around OH2 build 454.
I have the following bindings installed:
Oddly, after doing an uninstall/install of the MAP transformation, sendMail started working again.
The text was updated successfully, but these errors were encountered: