Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace double percent sign in chart unit, fixes #870, fixes #928 #976

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Replace double percent sign in chart unit, fixes #870, fixes #928 #976

merged 1 commit into from
Mar 25, 2021

Conversation

hubsif
Copy link
Contributor

@hubsif hubsif commented Mar 25, 2021

Pragmatic fix of double percent sign in charts. Does not address the general unit detection flaws mentioned in comment in #928

@hubsif hubsif requested a review from a team as a code owner March 25, 2021 21:02
@relativeci
Copy link

relativeci bot commented Mar 25, 2021

Job #43: Bundle Size — 10.88MB (~-0.01%).

0ce07d1 vs ccf97d7

Changed metrics (2/8)
Metric Current Baseline
Initial JS 1.59MB(~-0.01%) 1.59MB
Cache Invalidation 15.85% 14.82%
Changed assets by type (1/7)
            Current     Baseline
JS 8.55MB (~-0.01%) 8.55MB

View Job #43 report on app.relative-ci.com

ghys
ghys approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable. I had planned to do exactly that, so thanks for doing it first!

@ghys ghys merged commit 7cbdc3c into openhab:main Mar 25, 2021
@ghys ghys added this to the 3.1 milestone Apr 1, 2021
@ghys ghys added bug Something isn't working main ui Main UI labels Apr 1, 2021
@ghys ghys added the patch A PR that has been cherry-picked to a patch release branch label Apr 18, 2021
ghys pushed a commit that referenced this pull request Apr 18, 2021
@hubsif @ghys
Replace double percent sign in chart unit, fixes #870, fixes #928 (#976)
762d46e 
Signed-off-by: Hubert Nusser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@hubsif @ghys