Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recalculate oh-slider when rendered, fixes #967 #975

Merged
merged 1 commit into from
Mar 26, 2021
Merged

recalculate oh-slider when rendered, fixes #967 #975

merged 1 commit into from
Mar 26, 2021

Conversation

hubsif
Copy link
Contributor

@hubsif hubsif commented Mar 25, 2021

No description provided.

@hubsif hubsif requested a review from a team as a code owner March 25, 2021 20:26
@relativeci
Copy link

relativeci bot commented Mar 25, 2021

Job #42: Bundle Size — 10.88MB (~+0.01%).

ccf97d7 vs eb6afdb

Changed metrics (2/8)
Metric Current Baseline
Initial JS 1.59MB(~+0.01%) 1.59MB
Cache Invalidation 14.82% 22.64%
Changed assets by type (1/7)
            Current     Baseline
JS 8.55MB (~+0.01%) 8.55MB

View Job #42 report on app.relative-ci.com

ghys
ghys approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be pretty harmless, I haven't found that it caused a regression in performance or rendering, so LGTM!

@ghys ghys merged commit 45b67da into openhab:main Mar 26, 2021
@ghys ghys added this to the 3.1 milestone Apr 1, 2021
@ghys ghys added bug Something isn't working main ui Main UI labels Apr 1, 2021
@ghys ghys added the patch A PR that has been cherry-picked to a patch release branch label Apr 18, 2021
ghys pushed a commit that referenced this pull request Apr 18, 2021
@hubsif @ghys
recalculate oh-slider when rendered, fixes #967 (#975)
f8fe2f5 
Signed-off-by: Hubert Nusser <[email protected]>
@ghys ghys mentioned this pull request Apr 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@hubsif @ghys