Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dialog on metadata removal #963

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Conversation

hubsif
Copy link
Contributor

@hubsif hubsif commented Mar 18, 2021

This fixes the dirty bug (😉) mentioned in PR945. Instead a dialog for removal confirmation is shown.

Signed-off-by: Hubert Nusser <[email protected]>
@hubsif hubsif requested a review from a team as a code owner March 18, 2021 18:50
@relativeci
Copy link

relativeci bot commented Mar 18, 2021

Job #33: Bundle Size — 10.88MB (~+0.01%).

b36e76e vs f7a966a

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 2.42% 0.39%
Changed assets by type (1/7)
            Current     Baseline
JS 8.55MB (+0.01%) 8.55MB

View Job #33 report on app.relative-ci.com

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ghys ghys merged commit 4311a9b into openhab:main Mar 18, 2021
@ghys ghys added this to the 3.1 milestone Apr 1, 2021
@ghys ghys added bug Something isn't working main ui Main UI labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants