Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor grid layout new item positioning #937

Merged
merged 1 commit into from
Mar 7, 2021

Conversation

ghys
Copy link
Member

@ghys ghys commented Mar 6, 2021

Fixes #835 (comment).
Generate docs for oh-grid-layout.
Minor labels, descriptions, styling fixes.

Move the ESLint plugin to production environments
only (the hot reloading is near unusable in dex mode
with the linting activated on save - the CI & release
builds will still fail but the developer is expected to
rely on an IDE extension or other means to ensure
the code is properly linted during development.

Signed-off-by: Yannick Schaus [email protected]

Fixes openhab#835 (comment).
Generate docs for oh-grid-layout.
Minor labels, descriptions, styling fixes.

Move the ESLint plugin to production environments
only (the hot reloading is near unusable in dex mode
with the linting activated on save - the CI & release
builds will still fail but the developer is expected to
rely on an IDE extension or other means to ensure
the code is properly linted during development.

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys requested a review from a team as a code owner March 6, 2021 18:03
@ghys ghys merged commit ba609e7 into openhab:main Mar 7, 2021
hoefnageltom pushed a commit to SoftwareArchitectureOpenHAB/openhab-webui that referenced this pull request Mar 20, 2021
Fixes openhab#835 (comment).
Generate docs for oh-grid-layout.
Minor labels, descriptions, styling fixes.

Move the ESLint plugin to production environments
only (the hot reloading is near unusable in dex mode
with the linting activated on save - the CI & release
builds will still fail but the developer is expected to
rely on an IDE extension or other means to ensure
the code is properly linted during development.

Signed-off-by: Yannick Schaus <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@ghys ghys added enhancement New feature or request main ui Main UI labels Apr 1, 2021
@ghys ghys added this to the 3.1 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant