Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Control-S save feature to item edit #842

Merged
merged 3 commits into from
Jan 24, 2021
Merged

Adding Control-S save feature to item edit #842

merged 3 commits into from
Jan 24, 2021

Conversation

bigbasec
Copy link
Contributor

Just adding the Cntl-S save feature to item edit so it's more in line with the rest of the GUI.

@bigbasec bigbasec requested review from ghys and a team as code owners January 24, 2021 05:06
@bigbasec bigbasec force-pushed the add_save_keystrokes branch from 907abe4 to 337e0f1 Compare January 24, 2021 05:07
bigbasec
bigbasec commented Jan 24, 2021
View reviewed changes
Copy link
Contributor Author

@bigbasec bigbasec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have botched the PR and committed local changes that aren't required. bundles/org.openhab.ui/web/src/pages/settings/items/item-edit.vue is the only file that would be changed here. I can resubmit if needed.

@ghys
Copy link
Member

ghys commented Jan 24, 2021

Yes, please make sure not to include files outside the scope of the PR. You can revert them with the suggestions here: https://stackoverflow.com/questions/215718/how-can-i-reset-or-revert-a-file-to-a-specific-revision

@bigbasec
Copy link
Contributor Author

Yes, please make sure not to include files outside the scope of the PR. You can revert them with the suggestions here: https://stackoverflow.com/questions/215718/how-can-i-reset-or-revert-a-file-to-a-specific-revision

Thank you. All fixed up now.

ghys
ghys approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ghys ghys merged commit 0426ad8 into openhab:main Jan 24, 2021
@bigbasec bigbasec deleted the add_save_keystrokes branch January 24, 2021 21:32
@ghys ghys added enhancement New feature or request main ui Main UI labels Jan 25, 2021
@ghys ghys added this to the 3.1 milestone Jan 25, 2021
bigbasec added a commit to bigbasec/openhab-webui that referenced this pull request Jan 28, 2021
@bigbasec
Adding Control-S save feature to item edit (openhab#842)
1b71f2c 
Signed-off-by: Brian Homeyer <[email protected]>
bigbasec added a commit to bigbasec/openhab-webui that referenced this pull request Jan 28, 2021
@bigbasec
Adding Control-S save feature to item edit (openhab#842)
ec82c65 
Signed-off-by: Brian Homeyer <[email protected]>
@bigbasec bigbasec restored the add_save_keystrokes branch January 29, 2021 13:18
@bigbasec bigbasec deleted the add_save_keystrokes branch February 5, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@bigbasec @ghys