Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't propagate loop to child widgets contexts #804

Merged

Conversation

ghys
Copy link
Member

@ghys ghys commented Jan 14, 2021

This prevents a loop context from being shared among
multiple instances of the same widget.

To pass elements of the parent loop context to widgets,
use props with an expression when configuring the widget:

config:
  prop1: =loop.i

Signed-off-by: Yannick Schaus [email protected]

This prevents a loop context from being shared among
multiple instances of the same widget.

To pass elements of the parent loop context to widgets,
use props with an expression when configuring the widget:
```
config:
  prop1: =loop.i
```

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys requested a review from a team as a code owner January 14, 2021 12:49
@ghys ghys added bug Something isn't working main ui Main UI labels Jan 14, 2021
@ghys ghys added this to the 3.1 milestone Jan 14, 2021
@ghys ghys merged commit 03aabb1 into openhab:master Jan 14, 2021
@ghys ghys deleted the no-loop-propagation-in-child-widgets-context branch January 14, 2021 14:08
ghys added a commit that referenced this pull request Jan 16, 2021
This prevents a loop context from being shared among
multiple instances of the same widget.

To pass elements of the parent loop context to widgets,
use props with an expression when configuring the widget:
```
config:
  prop1: =loop.i
```

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys added the patch A PR that has been cherry-picked to a patch release branch label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant