Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take all door subclasses in door location glance badge (except GarageDoor) #727

Merged
merged 2 commits into from
Jan 3, 2021

Conversation

garthy
Copy link
Contributor

@garthy garthy commented Dec 29, 2020

Include all the doors in the location not just Door and FrontDoor

@garthy garthy requested a review from a team as a code owner December 29, 2020 15:42
@garthy garthy force-pushed the bug/include-all-doors branch from d127d15 to d0459ab Compare December 29, 2020 15:52
Signed-off-by: Garth Bushell <[email protected]>
@garthy garthy force-pushed the bug/include-all-doors branch from d0459ab to bc6d595 Compare December 29, 2020 15:55
@ghys ghys added the rebuild trigger a new Jenkins job label Dec 31, 2020
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghys ghys merged commit 813aa25 into openhab:master Jan 3, 2021
crnjan added a commit to crnjan/openhab-webui that referenced this pull request Jan 6, 2021
* master:
  Take all door subclasses in door location glance badge (openhab#727)
  [habpanel] Remove ItemStateEvent detection (openhab#737)
  Update license headers to 2021 (openhab#739)
  Fix openhab#714 - Sort popup dialogs by name and jump to selected item on open (openhab#724)
  Fix openhab#538 - Do not concatenate search for items (openhab#726)
  Fix openhab#722 - Show current GA metadata when editing (openhab#723)
  Fix openhab#720 - Fix various problems with google assistant metadata UI (openhab#721)
  Fix openhab#684 - Allow diacritics in search bars (openhab#718)
  CSP: allow blob: URLs (openhab#698)
  Apply Spotless (openhab#680)
  [unleash-maven-plugin] Preparation for next development cycle.
@ghys ghys added the bug Something isn't working label Jan 11, 2021
@ghys ghys added this to the 3.1 milestone Jan 11, 2021
ghys pushed a commit to ghys/openhab-webui that referenced this pull request Jan 11, 2021
(except GarageDoor which has its own badge)

Signed-off-by: Garth Bushell <[email protected]>
@ghys ghys added patch A PR that has been cherry-picked to a patch release branch main ui Main UI labels Jan 11, 2021
@ghys ghys changed the title Add all the doors Take all door subclasses in door location glance badge (except GarageDoor) Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch rebuild trigger a new Jenkins job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants