Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor websocket code to $oh namespace #2907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

florian-h05
Copy link
Contributor

This refactors the WebSocket connection code from #2884 to the $oh namespace,
same as it is for the SSE logic.

@florian-h05
Copy link
Contributor Author

@ghys This refactors the WS to the $oh namespace.
Let's postpone merging this after the release to not impose any risks.

Copy link

relativeci bot commented Dec 9, 2024

#2570 Bundle Size — 10.9MiB (~+0.01%).

ad25fa0(current) vs 511b949 main#2569(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#2570
     Baseline
#2569
Regression  Initial JS 1.92MiB(+0.08%) 1.92MiB
No change  Initial CSS 577.83KiB 577.83KiB
Change  Cache Invalidation 17.65% 17.83%
No change  Chunks 226 226
No change  Assets 249 249
Change  Modules 2948(+0.03%) 2947
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2570
     Baseline
#2569
Regression  JS 9.11MiB (+0.01%) 9.11MiB
No change  CSS 866.74KiB 866.74KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:ws-rfcProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 force-pushed the ws-rfc branch 2 times, most recently from 89e59d9 to d9ba1a5 Compare December 17, 2024 15:09
@florian-h05 florian-h05 marked this pull request as ready for review December 17, 2024 15:29
@florian-h05 florian-h05 requested a review from ghys as a code owner December 17, 2024 15:29
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Dec 17, 2024
@florian-h05 florian-h05 added this to the 5.0 milestone Dec 17, 2024
@florian-h05
Copy link
Contributor Author

@ghys Can you please have a look at this PR?

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good but I'd still prefer the access token to be passed in headers instead of the URL query: openhab/openhab-core#4490
(at least when possible)

This reduces the odds that it could appear in a log.
Even if ephemeral, tokens should never be logged.

If it's urgent please merge but otherwise I don't see why the rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants