Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config sheet: Always show advanced params only if changed from default #2888

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Dec 1, 2024

Improve code from #2313.
Closes #2879.

Copy link

relativeci bot commented Dec 1, 2024

#2518 Bundle Size — 10.87MiB (~-0.01%).

4481514(current) vs d432f3b main#2515(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#2518
     Baseline
#2515
Improvement  Initial JS 1.91MiB(~-0.01%) 1.91MiB
No change  Initial CSS 577.48KiB 577.48KiB
Change  Cache Invalidation 19.4% 18.34%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2942 2942
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#2518
     Baseline
#2515
Improvement  JS 9.08MiB (~-0.01%) 9.08MiB
No change  CSS 864.45KiB 864.45KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:config-advanced-para...Project dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 force-pushed the config-advanced-params branch from 361f7a2 to 4481514 Compare December 3, 2024 16:39
@florian-h05 florian-h05 changed the title Config sheet: Improve advanced params conditional visibility code Config sheet: Always show advanced params only if changed from default Dec 3, 2024
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Dec 3, 2024
@florian-h05 florian-h05 added this to the 4.3 milestone Dec 3, 2024
@florian-h05 florian-h05 marked this pull request as ready for review December 3, 2024 20:08
@florian-h05 florian-h05 requested a review from ghys as a code owner December 3, 2024 20:08
@florian-h05 florian-h05 merged commit 1258cf0 into openhab:main Dec 3, 2024
8 checks passed
@florian-h05 florian-h05 deleted the config-advanced-params branch December 3, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thing configuration "show advanced" doesn't work properly
1 participant