Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-ons store: Improve card sizing on desktop #2859

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Nov 2, 2024

Use grid instead of flex with a minimum card width and automatic sizing.
Looks nearly the same on smaller screens and much better on large screens.

Also limit width of single add-on card in swiper component as a safeguard.

@florian-h05 florian-h05 added this to the 4.3 milestone Nov 2, 2024
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Nov 2, 2024
Copy link

relativeci bot commented Nov 2, 2024

#2458 Bundle Size — 10.86MiB (~-0.01%).

b2e74e3(current) vs 7602f71 main#2456(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2458
     Baseline
#2456
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.31KiB 577.31KiB
Change  Cache Invalidation 17.73% 18.18%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2938 2938
No change  Duplicate Modules 151 151
No change  Duplicate Code 1.87% 1.87%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#2458
     Baseline
#2456
Regression  JS 9.07MiB (~+0.01%) 9.07MiB
Improvement  CSS 864KiB (-0.04%) 864.37KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch florian-h05:addons-storeProject dashboard


Generated by RelativeCIDocumentationReport issue

@florian-h05 florian-h05 changed the title Addons store: Improve card sizing on grid Add-ons store: Improve card sizing on grid Nov 2, 2024
@florian-h05 florian-h05 changed the title Add-ons store: Improve card sizing on grid Add-ons store: Improve card sizing on desktop Nov 2, 2024
@florian-h05 florian-h05 marked this pull request as ready for review November 2, 2024 23:03
@florian-h05 florian-h05 requested a review from ghys as a code owner November 2, 2024 23:03
@florian-h05 florian-h05 merged commit 1612d50 into openhab:main Nov 2, 2024
8 checks passed
@florian-h05 florian-h05 deleted the addons-store branch November 2, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant